Repository navigation
chore(quality): ratchet file-size baseline down after the combo/chatCore decompositions (rail G2) - #16070
Merged
Conversation
…ore decompositions (rail G2) Run check:file-size --update on release/v3.8.52 @35ef635c. combo.ts drops out of the baseline (4080 -> 1198, under the 1200 cap) and chatCore.ts tightens 6426 -> 3938 after #12746/#12811 and #14725. 29 more frozen ceilings lowered, 3 more entries removed as under cap, 6 testFrozen ceilings lowered. Down-only: no ceiling raised, no entry added. Frozen file entries 67 -> 63.
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
…-g2-file-size-ratchet
diegosouzapw
added a commit
that referenced
this pull request
Oct 11, 2026
…6147) Merged with the owner's 2026-10-10 hold/backlog wave. Reworked to keep frozen files within config/quality/file-size-baseline.json after #16070 ratcheted it down (logic extracted into new modules, no baseline raised). Validated together with #16147/#16112/#16110/#15790 on top of release/v3.8.52: typecheck:core, open-sse and API-route typecheck, eslint on changed files, complexity/cognitive ratchets, changelog-integrity green; 117/117 changed tests; only file-size overrun is the inherited executeTargetAttempt.ts. Warning: base-red inherited: #15306.
diegosouzapw
added a commit
that referenced
this pull request
Oct 11, 2026
Merged with the owner's 2026-10-10 hold/backlog wave. Reworked to keep frozen files within config/quality/file-size-baseline.json after #16070 ratcheted it down (logic extracted into new modules, no baseline raised). Validated together with #16147/#16112/#16110/#15790 on top of release/v3.8.52: typecheck:core, open-sse and API-route typecheck, eslint on changed files, complexity/cognitive ratchets, changelog-integrity green; 117/117 changed tests; only file-size overrun is the inherited executeTargetAttempt.ts. Warning: base-red inherited: #15306.
diegosouzapw
added a commit
that referenced
this pull request
Oct 11, 2026
…16110) Merged with the owner's 2026-10-10 hold/backlog wave. Reworked to keep frozen files within config/quality/file-size-baseline.json after #16070 ratcheted it down (logic extracted into new modules, no baseline raised). Validated together with #16147/#16112/#16110/#15790 on top of release/v3.8.52: typecheck:core, open-sse and API-route typecheck, eslint on changed files, complexity/cognitive ratchets, changelog-integrity green; 117/117 changed tests; only file-size overrun is the inherited executeTargetAttempt.ts. Warning: base-red inherited: #15306.
diegosouzapw
added a commit
that referenced
this pull request
Oct 11, 2026
…overs the connection (#15790) Merged with the owner's 2026-10-10 hold/backlog wave. Reworked to keep frozen files within config/quality/file-size-baseline.json after #16070 ratcheted it down (logic extracted into new modules, no baseline raised). Validated together with #16147/#16112/#16110/#15790 on top of release/v3.8.52: typecheck:core, open-sse and API-route typecheck, eslint on changed files, complexity/cognitive ratchets, changelog-integrity green; 117/117 changed tests; only file-size overrun is the inherited executeTargetAttempt.ts. Warning: base-red inherited: #15306.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rail gate G2 (3.8.52). The god-file decompositions landed (#12746/#12811 for
combo.ts, #14725 forchatCore.ts), butconfig/quality/file-size-baseline.jsonstill froze both at their pre-split sizes: 4080 and 6426. That left ~2.9k and ~2.5k lines of headroom for the files to grow back with no alarm. This PR runs the gate's own ratchet (check:file-size -- --update, which can only lower ceilings or drop entries that already fit under the cap) and records a note explaining the re-tightening.What changed
Only
config/quality/file-size-baseline.json.open-sse/services/combo.tsopen-sse/handlers/chatCore.tsSame pass:
frozenceilings lowered to their measured size (largest:ApiManagerPageClient.tsx3186 → 1318;codex.ts1584 → 1526).executors/chatgpt-web.ts(5056),executors/muse-spark-web.ts(1405),handlers/chatCore/nonStreamingResponse.ts(1212),mcp-server/server.ts(1572),proxySubscription/subscriptionService.ts(1212).testFrozenceilings lowered.frozen67 → 62,testFrozen30 → 30. The 131 nested note keys and every top-level key are unchanged._rebaseline_2026_10_09_rail_g2at the top, matching the existing notes.Down-only, verified with a key-by-key before/after comparison: no ceiling raised, no entry added, no duplicate key lost. The diff is larger than the value changes because
--updatere-sorts the keys insidefrozen/testFrozen; those moves are order-only.Validation
npm run check:file-sizenpm run check:file-size -- --updatenpm run check:file-sizenpm run check:file-size -- --base-ref origin/release/v3.8.52node --import tsx/esm --test tests/unit/check-file-size.test.tsnpx prettier --check config/quality/file-size-baseline.jsonMeasured on the fresh tip
7510677f2f(re-measured after the base advanced 125 commits; the first pass frozecodex.tsat 1519 and failed CI once #15926 landed).