Repository navigation
fix(db): avoid maintenance scans in inference settings reads - #16037
Merged
diegosouzapw merged 2 commits intoOct 10, 2026
Merged
diegosouzapw merged 2 commits into
diegosouzapw merged 2 commits into
Conversation
This was referenced Oct 9, 2026
insoln
marked this pull request as ready for review
October 9, 2026 13:48
diegosouzapw
merged commit Oct 10, 2026
853e6a2
into
cheaper-inference:release/v3.8.52
74 of 154 checks passed
Collaborator
|
Thanks @insoln — inference and semantic-cache reads use per-user database settings and skip the database-wide integrity scan. This is in the upcoming release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getDatabaseSettings()reader withgetUserDatabaseSettings()in semantic-cache configuration and embeddings, rerank, audio transcriptions, and audio translations combo dispatch.Related Issues
Closes #16036
Validation
npm run check:migration-numbering,npm run check:db-rules, andnpm run check:changelog-integritypassed.npm run lint: fivereact-hooks/immutabilityerrors in untouched UI hook tests (use-improve-prompt,use-presets,use-stream-metrics,use-structured-output,use-tools-builder) and one unused-disable warning in untouchedFeatureFlagsGrid.tsx. Focused lint on changed files passes.npm run typecheck:core: 11 diagnostics involving installed omniglyph/sharp types. The untouched base at f9989a1 produces byte-identical diagnostic output using the same local dependencies.npm run test:vitest: fails before executing tests withbuiltin:vite-wasm-fallback/BindingBuiltinPluginName. Reproduced on the untouched base with the same local dependencies.Tests Added Or Updated
tests/unit/semantic-cache-settings-no-maintenance.test.ts: master/vector toggle matrix, TTL/capacity/threshold preservation, and no database-wide maintenance during config resolution.tests/unit/inference-combo-settings-no-maintenance.test.ts: successful synthetic dispatch through all four modality combo handlers without diagnostic scans.Coverage Notes
The new tests exercise all five changed readers through the real DB bridge or handlers. Existing administrative database-maintenance tests still pass. No coverage percentage claim is made; CI will measure coverage.
Reviewer Notes
No migrations, new settings, dependencies, changes to cache defaults, or disabled integrity checks. All reproductions use synthetic local data and mocked providers; no production data or infrastructure details are included.
Review readiness update
Marked ready for review to enable the full PR validation workflows. Draft PRs skip the substantive CI jobs, and the aggregate gates explicitly reject draft readiness. Existing validation limitations and the base-red warning above remain applicable; this status change does not assert a green full suite or authorize merging.