Repository navigation
fix(profile): format XP numbers with the UI locale - #16008
Merged
diegosouzapw merged 3 commits intoOct 16, 2026
Merged
diegosouzapw merged 3 commits into
diegosouzapw merged 3 commits into
Conversation
The Profile page already uses the next-intl locale for dates but formatted the XP progress and total XP with toLocaleString() and no argument, so they followed the browser locale instead of the language chosen in OmniRoute.
Collaborator
|
Hi @pacocartones — closing this pull request to clear the open queue. The branch |
Collaborator
|
Hi @pacocartones — reopening this pull request. The close was a mistake, and it is back in the merge queue. The branch |
diegosouzapw
merged commit Oct 16, 2026
0fa38bb
into
cheaper-inference:release/v3.8.52
29 of 51 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x / y XP) and the total XP withtoLocaleString()and no argument, so they followed the browser locale instead of the language selected in OmniRoute. The page already passesuseLocale()to its dates; pass it to these two numbers too.Related Issues
Validation
tests/unit/ui/profile-xp-locale.test.tsx(localede, level 10, 1500 XP into the level): fails on the base ("1,500 /"), passes with the change; the three existing Profile UI tests still passprettier --checkOK;npm run lint(whole repo) passes on the branchTests Added Or Updated
tests/unit/ui/profile-xp-locale.test.tsx(new).Coverage Notes
src/app/(dashboard)/dashboard/profile/page.tsx, covered by the new test.Reviewer Notes
toLocaleString-style calls elsewhere alone.