Repository navigation
fix(oauth): harden Muse device responses while preserving renewal - #15920
Merged
diegosouzapw merged 1 commit intoOct 9, 2026
Merged
Conversation
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This was referenced Oct 9, 2026
This was referenced Oct 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #15869.
Muse Code accepted upstream device verification links without origin validation and passed arbitrary poll errors/descriptions into the shared OAuth result. This ports the device-response protections from the closed #14267 onto the current renewable implementation: HTTPS auth.meta.com only, no embedded credentials, bounded numeric device-code expiry, fixed polling error codes, malformed-response handling, redirect rejection and a 20-second request timeout.
The DCA lifecycle remains intact: postExchange, mapTokens and the remint provider are unchanged. Valid plain-only verification links remain supported. The new persistence regression writes both DCA-only and minted connections to disposable SQLite, reloads the database, and remints an inference key from the persisted DCA credential.
Validation:
f9989a1469a424847ba8e67b331351b7c352968d: 37 tests, 32 failures and 5 passing controls before production changes.No live Meta login or credential changes were performed. This PR leaves #15869 open for hosted CI, review and merge; no claim that those remote gates have already passed.
Release-green tracker #15306 remains open. A failure is only attributed to the base after comparing its exact signature on this candidate’s base; no gate or baseline is relaxed.
Dashboard typecheck remains red with the same three diagnostic groups reproduced on untouched exact base
f9989a1469a424847ba8e67b331351b7c352968d:useModelImportHandlers.tsTS2339 (17), TS2345 (1), andengineConfigSave.tsTS2345 (1). Candidate and base checks both exited 1; this patch does not modify those paths or relax the baseline.Normal commit hooks passed, including lint-staged, gate manifest, documentation sync, any-budget, tracked-artifacts and attribution checks. Independent source review found no blocker in the scoped device-code changes.