Repository navigation
fix(providers): honor custom vision override when combo step uses custom node alias prefix (#15563) - #15806
Merged
Conversation
…tom node alias prefix (#15563)
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15563
Root cause
Combo steps for custom OpenAI-compatible nodes are serialized (since #14143) as
{ providerId: "openai-compatible-chat-<uuid>", model: "<nodePrefix>/<bareId>" }, while the Custom Models vision row is keyed by the bare id.stripOwnProviderPrefix(#14642) only stripped prefixes resolving through the static provider-alias registry, so a custom node's own prefix was kept, the override lookup missed,supportsVisionwas null and the combo returned 400capability_mismatch.Fix
stripOwnProviderPrefixnow also strips the prefix when it equals (case-insensitive) the step provider's ownprovider_nodes.prefix(new sync helpersrc/lib/db/providers/nodePrefix.ts). Verbatim-id and known-registry-model guards are unchanged; other providers' prefixes are not stripped.Test (RED -> GREEN)
tests/unit/combo-vision-custom-node-alias-prefix-15563.test.ts: bare-id control passes; the two prefixed-form assertions were RED on the unfixed base (null !== true,true !== false, per the triage run on release/v3.8.52), all 4 GREEN now (incl. a negative for a foreign prefix). Related suites (combo-vision-aware-routing, vision-bridge-custom-*, repro-8429, model-capabilities-provider-unsupported-tools) pass.Gates
check-file-size, check-complexity, check-cognitive-complexity, eslint (with suppressions), typecheck:core, pre-commit hooks.