Repository navigation
Conversation
The combo create and update schemas omitted universal_handoff, so Zod stripped it before the route wrote the combo and an operator could not turn handoff off. The runtime already reads combo.universal_handoff or combo.universalHandoff, falling back to the process default when neither is stored. Accept both keys, and treat a payload that carries only the handoff setting as a real update. The process-wide default stays enabled. Signed-off-by: Minxi Hou <houminxi@gmail.com>
Collaborator
|
Thanks for the per-combo universal handoff setting. #15459 is the version that landed on release/v3.8.52 (274ea10): it persists and clears the camelCase alias on the combo route and schema, covered by tests/unit/combo-universal-handoff-15251.test.ts. This PR touches the same schema and test. Closing it so the two handoff changes are not both applied. None of this diff is being reused on top of #15459. The branch stays in place. |
This was referenced Oct 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
universal_handoff, so Zod stripped the field before the route wrote the combo.combo.universal_handofforcombo.universalHandoffand falls back to the process default when neither is stored. The default stays enabled.Related Issues
Validation
node --import tsx/esm --test tests/unit/combo-universal-handoff-15251.test.ts(4 pass)eslinton the changed file, with the repo suppression filerelease/v3.8.52@23a1148486Tests Added Or Updated
tests/unit/combo-universal-handoff-15251.test.ts(added)Coverage Notes
Reviewer Notes
open-sse/services/contextHandoff.tsis left atenabled: true. Flipping it would change behavior for every existing combo and is a separate decision.universal_handoffanduniversalHandoff, the runtime reads the snake_case value first (comboSetup.ts).