Skip to content

fix(logging): omit request body before pipeline in call-log size fallback - #14253

Merged
diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.51from
maxmad64bis:fix/call-log-artifact-pipeline-order
Sep 22, 2026
Merged

diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.51from
maxmad64bis:fix/call-log-artifact-pipeline-order

Conversation

@maxmad64bis

@maxmad64bis maxmad64bis commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ base-red inherited: #13866

Summary

When a call-log artifact exceeds the size cap, the storage fallback dropped the whole pipeline (including the upstream reply) before omitting the request and response bodies. Bodies are now omitted first, so an artifact that only overflows through its request body keeps the provider response — the part that says why a call failed. Artifacts whose pipeline alone overflows keep the previous behavior.

Related Issues

Validation

  • Change type: other (observability storage fallback)
  • Focused tests and category gates from the golden path
  • npm run lint — ESLint on the two touched files is clean; the full run is red on the base (🔴 Release branch not green: release/v3.8.51 #13866), unrelated to this diff
  • Reconciled with the current active release base; focused checks rerun afterward
  • Production-code changes include a new or updated automated test in this PR

Tests Added Or Updated

  • tests/unit/call-log-artifact-bodies-first.test.ts (extended, RED-then-GREEN: body-overflow keeps pipeline.provider_response, pipeline-only keeps the previous fallback, double size assertion against the same budget as the code)
  • Neighbors re-run green: size-limit-error, pipeline-precedence, file-rotation, log-export-runner (34 pass)

Coverage Notes

  • src/lib/usage/callLogArtifacts.ts is covered by the extended test file (7 cases over the reordered fallback).
  • No coverage movement beyond the fallback reorder.

Reviewer Notes

@maxmad64bis
maxmad64bis force-pushed the fix/call-log-artifact-pipeline-order branch from da87d89 to e6adf99 Compare September 20, 2026 09:08
@maxmad64bis
maxmad64bis marked this pull request as ready for review September 20, 2026 09:10
@diegosouzapw
diegosouzapw merged commit 30d0158 into cheaper-inference:release/v3.8.51 Sep 22, 2026
15 of 25 checks passed
@maxmad64bis
maxmad64bis deleted the fix/call-log-artifact-pipeline-order branch September 24, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants