Repository navigation
fix(logging): omit request body before pipeline in call-log size fallback - #14253
Merged
diegosouzapw merged 1 commit intoSep 22, 2026
Conversation
maxmad64bis
force-pushed
the
fix/call-log-artifact-pipeline-order
branch
from
September 20, 2026 09:08
da87d89 to
e6adf99
Compare
maxmad64bis
marked this pull request as ready for review
September 20, 2026 09:10
diegosouzapw
merged commit Sep 22, 2026
30d0158
into
cheaper-inference:release/v3.8.51
15 of 25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a call-log artifact exceeds the size cap, the storage fallback dropped the whole pipeline (including the upstream reply) before omitting the request and response bodies. Bodies are now omitted first, so an artifact that only overflows through its request body keeps the provider response — the part that says why a call failed. Artifacts whose pipeline alone overflows keep the previous behavior.
Related Issues
Validation
npm run lint— ESLint on the two touched files is clean; the full run is red on the base (🔴 Release branch not green: release/v3.8.51 #13866), unrelated to this diffTests Added Or Updated
tests/unit/call-log-artifact-bodies-first.test.ts(extended, RED-then-GREEN: body-overflow keepspipeline.provider_response, pipeline-only keeps the previous fallback, double size assertion against the same budget as the code)Coverage Notes
src/lib/usage/callLogArtifacts.tsis covered by the extended test file (7 cases over the reordered fallback).Reviewer Notes
typecheck:coreis clean and ESLint on touched files is clean.truncateArtifactForStorageand the debug-file path untouched; inherited set matches feat(db): add per-proxy egress IP lookup by host and port #14250 (identical comparison with third-party fix(translator): parse DeepSeek Web DSML tool calls #14249, comm empty).release/v3.8.51fails the same 9 jobs (API Route Typecheck, Docs Gates, Fast Quality Gates, Merge integrity, ESLint, Unit fast-path 1-4/4); every file cited by the failing gates is outside this diff. Non-blocking for this PR.