Skip to content

fix(sse): single retry over untried proxies after rate-limited wave stop - #13658

Closed
maxmad64bis wants to merge 2 commits into
cheaper-inference:release/v3.8.51from
maxmad64bis:fix/rate-limited-429-retry-v2
Closed

maxmad64bis wants to merge 2 commits into
cheaper-inference:release/v3.8.51from
maxmad64bis:fix/rate-limited-429-retry-v2

Conversation

@maxmad64bis

@maxmad64bis maxmad64bis commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Stacked on #13657. Only the last commit is this PR's scope; rebase onto the release base once #13657 lands.

Summary

When the first pass stops early, some accounts were never tried. This change spends them exactly once, within a single 90-second deadline, then drains like #13657. If none is left it drains directly. Only this PR's last commit is in scope.

Related Issues

Validation

  • Change type: provider
  • Focused tests and category gates from the golden path
  • npm run lint — clean on the touched files; the full run is red on the base (inherited, out of scope)
  • Reconciled with the current active release base; focused checks rerun afterward
  • Production-code changes include a new or updated automated test in this PR

Tests Added Or Updated

Coverage Notes

Same health gate as #13657; no new persisted state. The retry relays the latest upstream Retry-After (headers re-read, no body read).

Reviewer Notes

@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thanks for pushing on the 429 handling. After reworking #13657 with the maintainer, nothing from this branch remained valid on its own: the retry pass over untried accounts either repeated what the default cross-account wave already does, or (with the early-stop flag on) cancelled the stop the operator had just chosen, and it counted any non-429 status as a success, swallowed network errors and ignored the client abort signal.

What was worth keeping — the rate-limited 429 classifier and returning the last real upstream 429 with its body and headers intact — landed through #13657 under your authorship. Closing this one as consolidated into #13657.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants