Repository navigation
fix(sse): single retry over untried proxies after rate-limited wave stop - #13658
Closed
maxmad64bis wants to merge 2 commits into
Closed
maxmad64bis wants to merge 2 commits into
maxmad64bis wants to merge 2 commits into
Conversation
maxmad64bis
force-pushed
the
fix/rate-limited-429-retry-v2
branch
from
September 14, 2026 16:39
52ce910 to
24ea91a
Compare
maxmad64bis
marked this pull request as ready for review
September 14, 2026 16:41
4 of 5 tasks
Collaborator
|
Thanks for pushing on the 429 handling. After reworking #13657 with the maintainer, nothing from this branch remained valid on its own: the retry pass over untried accounts either repeated what the default cross-account wave already does, or (with the early-stop flag on) cancelled the stop the operator had just chosen, and it counted any non-429 status as a success, swallowed network errors and ignored the client abort signal. What was worth keeping — the rate-limited 429 classifier and returning the last real upstream 429 with its body and headers intact — landed through #13657 under your authorship. Closing this one as consolidated into #13657. |
Merged
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the first pass stops early, some accounts were never tried. This change spends them exactly once, within a single 90-second deadline, then drains like #13657. If none is left it drains directly. Only this PR's last commit is in scope.
Related Issues
5xx/cut).Validation
npm run lint— clean on the touched files; the full run is red on the base (inherited, out of scope)Tests Added Or Updated
tests/unit/opencode-rate-limited-classify.test.tsextended (wave stop, retry visits untried accounts only, drain carries both headers; 11 tests green with the 9 from fix(sse): stop retry wave on rate-limited 429 and drain 429 once #13657).typecheck:coreclean, targeted eslint clean, file-size OK, new-code complexity green.Coverage Notes
Same health gate as #13657; no new persisted state. The retry relays the latest upstream
Retry-After(headers re-read, no body read).Reviewer Notes
Retry-Afteris accepted and normalized by the same parser, so no format falls through.