Repository navigation
feat(dashboard): add a dedicated API-key routing editor - #13555
diegosouzapw merged 5 commits into
Conversation
|
Nice UX improvement — moving routing-rule editing into its own full-width workspace makes sense |
|
Thanks for checking the CI subset. I explicitly reran I also tested a separate local integration checkout containing #13554: the same 6 UI tests pass there. There is a small actual merge conflict at the imports and old card wrapper, so it should not be treated as an automatic clean merge. Resolution: keep this PR's redesigned workspace, import the service-mode component, and render it for the selected key (keyed by its ID, and only when the key exists and loading succeeded). No service-mode implementation was pulled into this PR. This is an explicit focused test result, not an inference from the curated CI fast-path checkmark. |
a167053
into
cheaper-inference:release/v3.8.51
…rence#13555) Merged. Moving rule editing out of the permissions modal into `/dashboard/api-manager/routing` fixes the real problem (a cramped modal for something with conditions, effects and three target kinds), and the contract tests pin what matters: persisted fields round-trip, combo names match without rewriting off-catalog IDs, failed saves stay editable, unsaved drafts survive key switches, and writes are disabled after a failed load. Rule evaluation and authorization are untouched. Validated as a combined board first (this PR merged with the 4 siblings of the JxnLexn wave on the release tip): eslint with the frozen suppressions, typecheck:core, check:open-sse-typecheck, complexity, cognitive-complexity, changelog-integrity, docs-sync, migration-numbering, provider-consistency and a duplicate-identifier audit all green, plus 77 passing / 0 failing focused node:test cases across the test files the wave touches. The wave's i18n fill (new keys carried to all 66 locales), free-tier doc counts and file-size rebaseline land in one follow-up PR right after the wave, as with cheaper-inference#13904. Thank you.
…-inference#13921) Lands the combined-board reconciliation of today's JxnLexn wave as one follow-up: i18n fill for cheaper-inference#12471/cheaper-inference#13555's new keys (real vi translations), free-tier count 446→452, file-size rebaseline for cheaper-inference#13556. check-new-key-coverage PASS; only the three pre-existing file-size reds remain.
Summary
Move routing-rule editing out of the cramped API-key permissions modal into a dedicated, full-width workspace at
/dashboard/api-manager/routing.This PR changes the editor only. It does not change rule evaluation, authorization, request routing, or service-tier precedence.
Related Issues
Historical base-red report #12732 is now closed. Current CI failures must be assessed on their own merits.
The feature was initially based on
release/v3.8.51at152d95108c9c3d557562311ffed63240a511eb31. No fork deployment workflow, container configuration, admission hotfix, or provider-catalog patch is included.Validation
npx vitest run tests/unit/ui/api-key-routing-editor.test.tsx— 6 passed, rerun on this branch.npx eslint tests/unit/ui/api-key-routing-editor.test.tsx— passed.git diff --checkpassed.Earlier manual checks exercised save/cancel and key selection. The equivalent fork deployment served the full-width page with HTTP 200 and preserved the existing routing configuration; that deployment is separate from this PR's CI evidence.
Tests Added Or Updated
tests/unit/ui/api-key-routing-editor.test.tsx: persisted-field round-trip, combo-name matching, failed-save drafts, unsaved-change confirmation, failed-load write protection, and full-width wrapper.Coverage Notes
The focused component tests cover the changed editor contract. Full coverage was not measured locally; the repository coverage gate remains a CI responsibility.
Reviewer Notes
No schema migration or provider credential changes. This branch can be reviewed independently from the runtime fixes. When combining with the per-key service-mode PR, retain its settings section in the selected-key workspace rather than restoring the old editor layout.
Related independent PRs
All three target the same release tip directly, not each other. Shared-file overlaps may need small integration resolutions after the first PR lands; unrelated fork-only changes are deliberately excluded.
Review follow-up: added
changelog.d/features/13555-api-key-routing-editor.md; the complete focused UI file passes 6/6 both on this branch and in a local checkout containing the per-key service-mode section. The curated CI fast path is not used as a substitute for this explicit test run.