Repository navigation
fix(dashboard): surface combined-pipeline error in Compression Studio Run (#12061) - #13288
Merged
Merged
Conversation
… Run (#12061) The combined-pipeline preview request's error was discarded (catch { combined = null; }), so a failed Run silently rendered nothing in the Play tab. Capture the error message on PreviewBatch.combinedError and render a visible error section when a run completes with no combined result. Regression test: tests/unit/ui/playViewCombinedError.test.tsx (RED before the fix, GREEN after).
diegosouzapw
force-pushed
the
fix/12061-compression-studio-run
branch
from
September 10, 2026 19:13
d4fde16 to
14823b8
Compare
7 tasks done
Githab-capibara
added a commit
to Githab-capibara/OmniRoute
that referenced
this pull request
Sep 17, 2026
… Run (cheaper-inference#12061) (cheaper-inference#13288) Merged as part of the 39-PR owner batch of 2026-09-11, validated as a unit. Boarded into one consolidated worktree cut from `release/v3.8.51` with the other 38 — zero conflicts between them. - ESLint over every changed file: no errors (the only finding was one suppression entry the batch emptied, pruned on cheaper-inference#13243) - `typecheck:core` clean; `check:dashboard-typecheck` OK (206 pre-existing, within baseline); `check:changelog-integrity` OK - complexity 2821 / baseline 3218 and cognitive-complexity 1272 / baseline 1437 — both under baseline - 256 assertions green: 246 under node:test and 10 under vitest, which is where `tests/unit/**/*.test.tsx` actually runs - `check-file-size`: `chatCore.ts` rebaselined 6144 → 6146 for cheaper-inference#13278 and cheaper-inference#13276, annotated and landed on cheaper-inference#13243⚠️ base-red inherited: cheaper-inference#12732 — the provider count (356 in the docs vs the 358 the modules define) and `open-sse/utils/stream.ts` at 3115 > frozen 3098 both reproduce on the pure tip with zero contribution from this batch.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
… Run (cheaper-inference#12061) (cheaper-inference#13288) Merged as part of the 39-PR owner batch of 2026-09-11, validated as a unit. Boarded into one consolidated worktree cut from `release/v3.8.51` with the other 38 — zero conflicts between them. - ESLint over every changed file: no errors (the only finding was one suppression entry the batch emptied, pruned on cheaper-inference#13243) - `typecheck:core` clean; `check:dashboard-typecheck` OK (206 pre-existing, within baseline); `check:changelog-integrity` OK - complexity 2821 / baseline 3218 and cognitive-complexity 1272 / baseline 1437 — both under baseline - 256 assertions green: 246 under node:test and 10 under vitest, which is where `tests/unit/**/*.test.tsx` actually runs - `check-file-size`: `chatCore.ts` rebaselined 6144 → 6146 for cheaper-inference#13278 and cheaper-inference#13276, annotated and landed on cheaper-inference#13243⚠️ base-red inherited: cheaper-inference#12732 — the provider count (356 in the docs vs the 358 the modules define) and `open-sse/utils/stream.ts` at 3115 > frozen 3098 both reproduce on the pure tip with zero contribution from this batch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12061
Root cause
Compression Studio's Play tab runs a combined-pipeline preview request in parallel with
per-lane preview requests.
runPreviewBatch()(src/hooks/usePreviewCompression.ts)wrapped the combined-pipeline
POST /api/compression/previewcall intry { ... } catch { combined = null; }, discarding the caught error entirely.PlayViewonly rendered the combined-result section when
batch?.combinedwas truthy(
src/app/(dashboard)/dashboard/compression/studio/PlayView.tsx:102), so a failed combinedrequest rendered nothing — no error, no placeholder — indistinguishable from an idle state.
Per-lane failures did show a terse "⚠ error", but the primary combined section stayed
completely silent on failure, matching the reported "Run returns no result" behavior.
Fix
src/hooks/usePreviewCompression.ts:PreviewBatchgained acombinedError: string | nullfield; the combined-pipeline
catchnow captures the error message instead of dropping it.src/app/(dashboard)/dashboard/compression/studio/PlayView.tsx: added adata-testid="play-combined-error"fallback section, rendered only after a run hascompleted (
batchnon-null) with no combined result and a captured error — never on theinitial/idle state.
src/i18n/messages/en.json: addedcompressionStudio.combinedError("Combined pipelinepreview failed: {reason}"). Propagated to the other 49 locales via
node scripts/i18n/sync-ui-keys.mjs(English source only; other locales carry the tracked__MISSING__:placeholder per the project's i18n convention — no hand-translation).Scope: this only addresses the silent-failure defect on the combined-result section, per the
issue's own final scoping comment. The separately reported "input gets cleared" symptom does
not reproduce in code (the
textstate lives in the parentpage.tsxand nothing inPlayView.tsx/PlaygroundInputtouches it) and is out of scope here.Regression test
tests/unit/ui/playViewCombinedError.test.tsx— mocks per-lane preview calls as succeedingwhile the combined-pipeline call returns a 500, renders
PlayView, clicks Run, and asserts avisible error is shown for the combined section instead of nothing.
RED (before fix):
GREEN (after fix):
Gates run
node scripts/check/check-file-size.mjs— no violations on touched filesnode scripts/check/check-complexity.mjs— OK (2798 violations, baseline 3218)node scripts/check/check-cognitive-complexity.mjs— OK (1265 violations, baseline 1437)npm run typecheck:core— cleannpm run check:dashboard-typecheck— OK, 206 pre-existing errors, all within frozen baseline (no new regressions)npx eslint --suppressions-location config/quality/eslint-suppressions.json <changed files>— cleannpx vitest run --config vitest.config.ts tests/unit/ui/playViewCombinedError.test.tsx— 1 passedtests/unit/ui/usePreviewCompression.test.tsx,tests/unit/ui/fidelityGateToggle.test.tsx,tests/unit/ui/fuzzyDedupToggle.test.tsx— allstill pass (3 files, 5 tests)
node scripts/i18n/check-ui-keys-coverage.mjs— PASS, all 50 locales ≥ 80% coveragenode scripts/check/check-changelog-integrity.mjs— OKNote:
tests/unit/ui/playView.test.tsxis pre-existing-excluded from the vitest UI configunder issue #8618 (unrelated to this change) and was left untouched.