[Bluscream]

Fixes #13063

Summary

For keyless providers (such as searxng-search), formData.apiKey is empty. validationPsd was previously scoped inside the if (!isOAuth && formData.apiKey) block, but referenced later in the scope when assigning updates.providerSpecificData.

Moving let validationPsd = validatedProviderSpecificData; out of the if (!isOAuth && formData.apiKey) block ensures validationPsd is always in scope when saving keyless provider connections.

[ekinnee]

@Bluscream target release/v3.8.51 please.

[Bluscream]

@ekinnee Rebased onto release/v3.8.51 and changed the PR base branch accordingly. Thanks!

[diegosouzapw]

Thanks for the fix and for rebasing onto release/v3.8.51! I checked the current tip and
let validationPsd = validatedProviderSpecificData; is already present at that exact spot
(it traces back to #8949, merged before your branch point) — so this PR's one-line change is
already on the tip and doesn't change behavior. Could you confirm whether the original
ReferenceError from #13063 still reproduces on current release/v3.8.51? If it doesn't, I'll
close this as already fixed; if it does, there's likely a different code path causing it and
I'd like to see the exact repro steps.

Triage note: this is the review recommendation — the close itself happens only after the maintainer's per-PR sign-off (and, where a superseding PR is named, after it has landed). Nothing is being closed by this comment.