Repository navigation
fix(i18n): add 4 missing EN source keys + i18n-gate CI (#12272) - #12614
KooshaPari wants to merge 1 commit into
Conversation
…-inference#12272) From the i18n audit (bin/i18n-audit.mjs --fix), 4 keys existed in 43 locale catalogs as __MISSING__: placeholders but were absent from en.json (the source-of-truth). This caused i18n:check to pass while i18n:strict-ui would have failed. Added to en.json: sidebar.trafficInspectorSubtitle providers.rateLimitOverridesMaxWaitMsHint / Label agentSkills.catalog.omni-webhooks.description scripts/i18n-gate.mjs: New CI gate — fails if any locale still contains __MISSING__: markers. Usage: node scripts/i18n-gate.mjs src/i18n/messages/ [--strict] This prevents the regression that produced cheaper-inference#12272: a sync-ui run that produced __MISSING__: sentinels for keys not in en.json. Fixes cheaper-inference#12272
Note (transparency)I'm posting this on the PRs I opened during a self-imposed WAITING window. There's a pending handoff in my local state ( What I'm doing now:
If any of these PRs shouldn't have been opened in your view, the comment-thread on each is the right place to flag it — I'll defer. Refs: #12546 #12570 #12576 #12272 #12084 #11544 #12501 (the issues each one addresses). — KooshaPari |
|
Closing this one on a base problem rather than anything wrong with the intent. The PR is cut from Merging it would delete keys the dashboard renders today. That is base drift, not authorship — the same commit rebased onto On If the 3 |
Summary
Fixes #12272 — 4 i18n keys that existed in 43 locale catalogs as
__MISSING__:placeholders but were absent fromen.json(the source of truth). This causedi18n:checkto pass whilei18n:strict-uiwould have caught them.Changes
src/i18n/messages/en.json: Added 4 missing keys:sidebar.trafficInspectorSubtitleproviders.rateLimitOverridesMaxWaitMsHint/LabelagentSkills.catalog.omni-webhooks.descriptionscripts/i18n-gate.mjs: New CI gate — fails if any locale still contains__MISSING__:markers.node scripts/i18n-gate.mjs src/i18n/messages/ [--strict]Prevention
The root cause was a
i18n:sync-uirun that produced__MISSING__:sentinels for keys not yet inen.json. The gate makes that regression impossible to ship silently.Fixes #12272