Repository navigation
fix(ci): clear base-reds on release/v3.8.51 - #12595
Merged
Merged
Conversation
Clear two HARD base-reds on release/v3.8.51 (#12581): next-intl's @eloqnt/* 0.0.x tarballs omit a license field (registry SPDX is MIT), and the A2A lifecycle vitest no longer opens real SQLite via default persistence.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…er-inference#12595) Validado numa worktree sobre o tip de `release/v3.8.51`. Verifiquei as premissas em vez de aceitar a justificativa: **Exceções de licença** — todas as afirmações batem. Os três pacotes estão instalados exatamente nas versões travadas citadas (`@eloqnt/config@0.0.2`, `@eloqnt/format-json@0.0.3`, `@eloqnt/format-po@0.0.3`), os três **omitem `package.json#license` e não têm arquivo LICENSE**, e `npm ls` confirma que são transitivos de `next-intl@4.14.1` (MIT). No registry, o SPDX das três é MIT e o `@eloqnt/config@0.1.0` existe, como o texto diz. Uso de `exceptions` (com `risk`/`reviewAt`) em vez de `allowed: UNKNOWN` é o mecanismo certo. `check:licenses` verde: **0 violações de política**, 948 permitidos, as três novas entradas aparecendo como exceções sinalizadas não bloqueantes ao lado das duas já existentes. Teste-guarda `tests/unit/build/check-licenses.test.ts`: **36/36**. **Vitest do A2A lifecycle** — as duas seams usadas já existiam antes deste PR: `constructor(ttlMinutes = 5, persistence: A2APersistence = defaultPersistence)` e o 4º parâmetro opcional `deps?: MemoryHitsDeps` de `executeA2ATaskWithState`. O padrão é idêntico ao que `tests/unit/a2a-task-persistence.test.ts` já fazia. Nenhuma asserção foi removida ou enfraquecida — e como o comportamento de persistência tem suíte dedicada, injetar no-ops aqui tira acoplamento incidental, não cobertura. Ganho medido nos dois lados: corpo dos testes **784ms no tip → 233ms com o PR**, sem nenhuma linha `[DB] SQLite database ready`. Registro honesto: **no tip o arquivo passa localmente** (4/4) — o red era do CI, sob o thread pool com as 167 migrações; localmente dá para comprovar o mecanismo e a aceleração, não a falha em si. Suíte vitest completa: **51/51 arquivos, 465/465 testes**.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears reproducible HARD failures from base-red #12581 (run 33720531420, tip
2a6d45abea). Does not merge.HARDs fixed
check:licenses@eloqnt/config@0.0.2: UNKNOWN(and the same unpublished-license hit on@eloqnt/format-json@0.0.3/@eloqnt/format-po@0.0.3). Transitive ofnext-intl. Registry SPDX is MIT (@eloqnt/config@0.1.0republished withlicense: MIT); the locked^0.0.20.0.x tarballs omit bothpackage.json#licenseand a LICENSE file. Documentedexceptionsentries inconfig/quality/.license-allowlist.json(notallowed: UNKNOWN). Guard:tests/unit/build/check-licenses.test.ts.open-sse/mcp-server/__tests__/a2aLifecycle.test.ts(A2A task lifecycle). DefaultA2ATaskManagerpersistence now writes SQLite (#12479/#12508), so this vitest file ran 167 migrations inside the thread pool and calledcollectMemoryHitsagainst the real memory backend. Injected the existing no-opA2APersistenceseam + no-op memory deps. Same 4 assertions; isolated run dropped from ~756ms with a live DB to 28ms with no[DB] SQLite database ready.HARDs not in this PR
check:openapi-security-tiersPOST/api/vnc-session/{params}— already fixed in open PR fix(ci): openapi-security-tiers checker honors routeGuard patterns + imported prefixes (base-red #12335) #12350 (fix/release-v3.8.51-openapi-security-tiers-checker, GREEN). HOLD; not duplicated.Unit suite timeout 4800s / integration timeout 2400s — not reproduced as a new unreleased DB handle.
t09-a2a-lifecycle.test.tsdoes open SQLite via default persistence but exits cleanly in isolation (~2.7s). Needs-owner (infra/hang unless a later session proves a leak).Package artifact:
Error: Turbopack build failed with 1 error:— GitHub job logs for run 33720531420 are truncated to the wrapper line; the next-line compile/panic detail is not in the uploadedrelease-green-report. Typecheck + dashboard-typecheck passed on that run. Not distinguished from the known Turbopack unreachable-code panic (OMNIROUTE_USE_TURBOPACK=0already on the docker-publish path). Did not edit.github/workflows/. Needs-owner.Tarball boot-smoke — skipped because pack-artifact did not produce
dist/. Follows pack-artifact.File-size ratchet
src/sse/handlers/chat.ts2434 > 2424 — drift, not rebaselined.fix(ci): document MIT exceptions for
@eloqnt/{config,format-json,format-po}(next-intl transitive; locked tarballs omitlicense) and keep the A2A lifecycle vitest off the real SQLite persistence seam (#12581)