Repository navigation
chore(quality): tighten the CodeQL ratchet baseline from 11 to 6 - #12530
Merged
Merged
Conversation
4 of 5 tasks
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…aper-inference#12530) Co-authored-by: Markus Hartung <diegosouzapw@users.noreply.github.com>
Bhavesh1236
pushed a commit
to Bhavesh1236/OmniRoute
that referenced
this pull request
Oct 9, 2026
…aper-inference#12530) Co-authored-by: Markus Hartung <diegosouzapw@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
A PR #12502 corrigiu 7 alertas CodeQL reais (aleatoriedade tendenciosa no signer do MaxAI, 2 sanitizações incompletas e 4 defeitos de correspondência de URL em testes). Após o merge, a análise CodeQL manualmente disparada publicou o resultado e fechou esses alertas — a contagem real de alertas abertos caiu de 13 para 6.
A catraca (
config/quality/quality-baseline.json→metrics.codeqlAlerts.value) ficou parada em 11, ou seja, permitia silenciosamente uma regressão de até 5 alertas antes de bloquear qualquer PR. Esta PR só atualiza esse valor para o número real.O que muda
config/quality/quality-baseline.json:metrics.codeqlAlerts.value11→6. Nenhum outro campo do arquivo foi tocado.Verificação
Contagem live confirmada via API antes e depois da atualização:
Breakdown por regra dos 6 alertas restantes:
js/weak-cryptographic-algorithmopen-sse/executors/maxai/signing.ts:56,open-sse/executors/maxai/constants.ts:279,tests/unit/helpers/maxaiMockConstants.ts:52js/insufficient-password-hashopen-sse/executors/maxai/signing.ts:76,open-sse/executors/maxai/signing.ts:56js/stack-trace-exposureopen-sse/utils/error.ts:749Todos os 6 estão pendentes de dismissal manual pelo operador (Hard Rule #14 — dismissal via API é proibido para agentes), com a justificativa técnica já registrada na PR #12502:
open-sse/executors/maxai/são exigidos pelo protocolo do provider MaxAI (o algoritmo fraco/hash é o que o upstream MaxAI exige para assinar requisições — não é escolha do OmniRoute).js/stack-trace-exposureemopen-sse/utils/error.ts:749é falso positivo — o callsite já passa porsanitizeErrorMessage()/buildErrorBody()(verdocs/security/ERROR_SANITIZATION.md); é uma limitação conhecida do CodeQL em reconhecer sanitizers customizados (mesma classe documentada na Hard Rule feat: add new endpoints (rerank, audio, moderations) and providers (Hyperbolic, Deepgram, AssemblyAI, NanoBanana) #14).Comandos executados:
Escopo
Apenas o valor da métrica
codeqlAlertsfoi alterado — nenhum outro campo/métrica do baseline foi tocado, nenhuma catraca foi afrouxada (é um aperto: 11 → 6).