Repository navigation
fix(quality): record the 2026-09-02 merged growth in the file-size baseline - #12434
Merged
Merged
Conversation
…seline check-file-size went red on release/v3.8.51 with nine violations: seven source files and two test files that the 2026-09-02 merge waves grew at existing chokepoints. The growth itself was reviewed — each file was measured and justified while validating the batches — but the rebaseline was computed in the throwaway combined validation worktree and never propagated to any contributor branch, so the code landed and the caps did not. This records the caps against the merged state, with each entry attributed to the PR that grew it. No cap is raised beyond the file's real merged LOC and no unrelated entry moves, so the ratchet #12411 re-tightened stays intact.
diegosouzapw
added a commit
that referenced
this pull request
Sep 2, 2026
…st the retired codex id (#12437) Drains the two remaining Fast Quality Gates reds the #11513 (UC) merge left on the tip: - error-helper: ucTts.ts and uc/ws.ts built error payloads from raw err.message (Hard Rule #12) — now wrapped in sanitizeErrorMessage(), behavior otherwise identical (uc suites 51/51). - model-lifecycle: the UC catalog registers the vendor-retired gpt-5.2-codex (bare id; only the prefixed openai/gpt-5.2-codex was allowlisted). Added to allowedRetiredInCatalog per its policy — forwarding globally would rewrite the just-approved provider's model. Tracking: Refs #12436. file-size, the third red of this window, was already drained by #12434.
diegosouzapw
added a commit
to backryun/OmniRoute
that referenced
this pull request
Sep 2, 2026
…ore-chatgpt-web-cleanroom Clean merge against the tip. The two chat chokepoints this PR grows (chat.ts +40, chatCore.ts +30) are recorded in the file-size baseline with an annotation; no other cap moves. The rebaseline is carried here rather than left in a validation worktree — the mistake that put the 2026-09-02 waves base-red (cheaper-inference#12434).
diegosouzapw
pushed a commit
that referenced
this pull request
Sep 2, 2026
…#12239) Restores ChatGPT Web on a clean-room browser transport, merged on the operator's explicit decision. Worth stating precisely, because this touches a provenance decision: the PR does not revert #11754. It narrows RETIRED_COMMON_CHATGPT_WEB_PROVIDER_IDS to the single GPL-derived alias cgpt-web and registers chatgpt-web as a separate clean-room id. The old implementation stays retired and blocked; the retirement machinery, its error code and its 410 contract are untouched. All four retirement suites agree with that distinction and pass unchanged. The 44 protected agent-instruction surfaces this PR touches (AGENTS.md, llm.txt and its 42 mirrors, README) were verified rather than trusted: masking digits and comparing the removed and added line sets gives 264 lines on each side, identical — every change is a provider-count substitution, with no sentence added, removed or reworded. Reconciled on merge: clean against the tip, with the two chat chokepoints this PR grows (src/sse/handlers/chat.ts +40, open-sse/handlers/chatCore.ts +30) recorded in the file-size baseline under an annotation. Verified that exactly those two caps move and nothing else, so the #12411 ratchet holds. The rebaseline is carried on this branch rather than left in a validation worktree — the propagation mistake that put the 2026-09-02 merge waves base-red in #12434. Verified: 504/504 across the PR's 44 test files plus all four chatgpt-web retirement suites, check:provider-consistency OK (272 REGISTRY entries, 355 canonical providers), check-file-size OK, and every changed TypeScript file parses. Thanks @backryun — separating the clean-room id from the retired alias, instead of reopening the old one, is what made this reviewable.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…seline (cheaper-inference#12434) check-file-size was red on release/v3.8.51 with nine violations — seven source files and two test files that the 2026-09-02 merge waves grew at existing chokepoints (cheaper-inference#12359-cheaper-inference#12404, cheaper-inference#11461, cheaper-inference#11513, cheaper-inference#12423). The growth itself was reviewed: each file was measured and justified while validating those batches. What went wrong is the propagation — the rebaseline was computed in the throwaway combined validation worktree, and the PRs were then merged individually through their own branches, so the code landed and the caps did not. A shared-file edit made only in the validation tree reaches nothing. This records the caps against the merged state, each entry attributed to the PR that grew it, under one _rebaseline annotation. Verified mechanically: 9 caps recorded, 0 raised beyond the file's real merged LOC, 0 unrelated entries moved — the ratchet cheaper-inference#12411 re-tightened is intact. Verified: check-file-size OK (135 frozen source entries across 4515 files; 39 frozen test entries across 5365), prettier clean.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…st the retired codex id (cheaper-inference#12437) Drains the two remaining Fast Quality Gates reds the cheaper-inference#11513 (UC) merge left on the tip: - error-helper: ucTts.ts and uc/ws.ts built error payloads from raw err.message (Hard Rule cheaper-inference#12) — now wrapped in sanitizeErrorMessage(), behavior otherwise identical (uc suites 51/51). - model-lifecycle: the UC catalog registers the vendor-retired gpt-5.2-codex (bare id; only the prefixed openai/gpt-5.2-codex was allowlisted). Added to allowedRetiredInCatalog per its policy — forwarding globally would rewrite the just-approved provider's model. Tracking: Refs cheaper-inference#12436. file-size, the third red of this window, was already drained by cheaper-inference#12434.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…cheaper-inference#12239) Restores ChatGPT Web on a clean-room browser transport, merged on the operator's explicit decision. Worth stating precisely, because this touches a provenance decision: the PR does not revert cheaper-inference#11754. It narrows RETIRED_COMMON_CHATGPT_WEB_PROVIDER_IDS to the single GPL-derived alias cgpt-web and registers chatgpt-web as a separate clean-room id. The old implementation stays retired and blocked; the retirement machinery, its error code and its 410 contract are untouched. All four retirement suites agree with that distinction and pass unchanged. The 44 protected agent-instruction surfaces this PR touches (AGENTS.md, llm.txt and its 42 mirrors, README) were verified rather than trusted: masking digits and comparing the removed and added line sets gives 264 lines on each side, identical — every change is a provider-count substitution, with no sentence added, removed or reworded. Reconciled on merge: clean against the tip, with the two chat chokepoints this PR grows (src/sse/handlers/chat.ts +40, open-sse/handlers/chatCore.ts +30) recorded in the file-size baseline under an annotation. Verified that exactly those two caps move and nothing else, so the cheaper-inference#12411 ratchet holds. The rebaseline is carried on this branch rather than left in a validation worktree — the propagation mistake that put the 2026-09-02 merge waves base-red in cheaper-inference#12434. Verified: 504/504 across the PR's 44 test files plus all four chatgpt-web retirement suites, check:provider-consistency OK (272 REGISTRY entries, 355 canonical providers), check-file-size OK, and every changed TypeScript file parses. Thanks @backryun — separating the clean-room id from the retired alias, instead of reopening the old one, is what made this reviewable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check-file-sizeis red onrelease/v3.8.51with nine violations — seven source files and two test files that today's merge waves grew at existing chokepoints:src/app/api/providers/[id]/models/route.tssrc/app/api/v1/models/catalog.tssrc/lib/db/core.tssrc/sse/handlers/chat.tssrc/sse/services/auth.tsopen-sse/handlers/imageGeneration.tsopen-sse/utils/proxyFetch.tstests/unit/image-generation-handler.test.tstests/unit/sse-auth.test.tsWhy it landed red
The growth was reviewed: each file was measured and justified while validating the batches. The rebaseline, however, was computed in the throwaway combined validation worktree and never propagated to a contributor branch — so the code landed and the caps did not. Merging batched PRs individually through their own branches does not carry a shared-file edit made only in the validation tree.
Scope
Baseline only, one file. Every entry is set to the file's real merged LOC and attributed to the PR that grew it, under a single
_rebaseline_2026_09_02_v3851_merged_growth_baseredsannotation. Verified mechanically: 9 caps recorded, 0 raised beyond the merged LOC, 0 unrelated entries moved — the ratchet #12411 re-tightened stays intact.Validation
node scripts/check/check-file-size.mjs→ OK (135 frozen source, 4515 files checked; 39 frozen test, 5365 checked).