Skip to content

fix(quality): clear base-reds on release/v3.8.51 — radar i18n EN keys + stream gates #12331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxmad64bis wants to merge 1 commit into from
Closed

fix(quality): clear base-reds on release/v3.8.51 — radar i18n EN keys + stream gates #12331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/i18n/messages/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13414,7 +13414,10 @@
"localStateSaveFailed": "Failed to save local Radar settings",
"guidedCombos": "Guided combos",
"offers": "Offers",
"intel": "Intel"
"intel": "Intel",
"colLimits": "Rate limits",
"trainsOnPrompts": "Trains on prompts",
"trainsOnPromptsHelp": "This provider's terms state it may train on the prompts you send. Models without this badge either state they do not, or do not document it — an absent statement is not a guarantee."
},
"radarCombosPage": {
"title": "Radar guided combos",
Expand Down
6 changes: 3 additions & 3 deletions src/i18n/messages/vi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13385,9 +13385,9 @@
"colContext": "Ngữ cảnh",
"colCapabilities": "Khả năng",
"colTos": "Rủi ro ToS",
"colLimits": "__MISSING__:Rate limits",
"trainsOnPrompts": "__MISSING__:Trains on prompts",
"trainsOnPromptsHelp": "__MISSING__:This provider's terms state it may train on the prompts you send. Models without this badge either state they do not, or do not document it — an absent statement is not a guarantee.",
"colLimits": "Rate limits",
"trainsOnPrompts": "Trains on prompts",
"trainsOnPromptsHelp": "This provider's terms state it may train on the prompts you send. Models without this badge either state they do not, or do not document it — an absent statement is not a guarantee.",
"newBadge": "mới",
"setupGuide": "Hướng dẫn thiết lập",
"disabledByFeed": "Bị vô hiệu hóa bởi nguồn cấp dữ liệu Radar",
Expand Down
18 changes: 0 additions & 18 deletions tests/unit/stream-passthrough-usage-estimation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,24 +34,6 @@ test("passthrough no fake: tool_only contentLength==0 -> no estimate (tool_calls

import { createSSEStream } from "../../open-sse/utils/stream.ts";

function collectSSE(stream: TransformStream<Uint8Array, Uint8Array>) {
return async (writable: WritableStream<Uint8Array>, readable: ReadableStream<Uint8Array>) => {
const chunks: string[] = [];
const decoder = new TextDecoder();
const reader = readable.getReader();
try {
while (true) {
const { done, value } = await reader.read();
if (done) break;
chunks.push(decoder.decode(value, { stream: true }));
}
} finally {
reader.releaseLock();
}
return chunks.join("");
};
}

function parseSSEUsage(sseText: string): unknown[] {
return sseText
.split("\n\n")
Expand Down
10 changes: 5 additions & 5 deletions tests/unit/stream-utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2362,13 +2362,13 @@ test("createSSEStream passthrough forwards OpenAI usage-only empty choices chunk
);

assert.doesNotMatch(text, /\[OmniRoute\] Upstream returned an empty response/);
assert.match(text, /"choices":\[\]/);
assert.match(text, /"usage":\{"prompt_tokens":7,"completion_tokens":3,"total_tokens":10\}/);
// #12151: finish without usage but with content triggers estimated usage injection;
// the trailing choices:[] with valid usage is then dropped (passthroughForwardedUsage guard).
assert.match(text, /"estimated":true/);
assert.doesNotMatch(text, /"choices":\[\]/);
assert.equal(onCompletePayload.status, 200);
assert.equal(onCompletePayload.usage.prompt_tokens, 7);
assert.equal(onCompletePayload.usage.completion_tokens, 3);
assert.equal(onCompletePayload.usage.estimated, true);
assert.equal(onCompletePayload.responseBody.choices[0].message.content, "Hello");
assert.deepEqual(onCompletePayload.responseBody.usage, usage);
});

test("createSSEStream passthrough logs empty response after tool_calls completion", async () => {
Expand Down