Skip to content

fix(quality): base-red pair — stryker tap registration + turn-pin suites aligned to the window gate #12255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 3 commits into from
Sep 1, 2026
Merged

fix(quality): base-red pair — stryker tap registration + turn-pin suites aligned to the window gate #12255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56ae688
chore(quality): register native-codex-turn-pin tests in stryker tap.t…
diegosouzapw Sep 1, 2026
eb41a5d
style: prettier pass on stryker.conf.json
diegosouzapw Sep 1, 2026
889a898
test(sse): align turn-pin suites to the provider-cooldown window gate
diegosouzapw Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion stryker.conf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,9 @@
"tests/unit/felo-web-runtime-block.test.ts",
"tests/unit/microsoft-designer-web-runtime-block.test.ts",
"tests/unit/qwen-web-runtime-block.test.ts",
"tests/unit/tunnel-routes-error-sanitization.test.ts"
"tests/unit/tunnel-routes-error-sanitization.test.ts",
"tests/unit/native-codex-turn-pin-10379.test.ts",
"tests/unit/native-codex-turn-pin-model-scoped-fallback.test.ts"
],
"nodeArgs": [
"--import",
Expand Down
9 changes: 7 additions & 2 deletions tests/unit/native-codex-turn-pin-10379.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const { getCircuitBreaker, resetAllCircuitBreakers } =
await import("../../src/shared/utils/circuitBreaker.ts");
const { recordProviderCooldown, clearCooldownState } =
await import("../../open-sse/services/providerCooldownTracker.ts");
const { PROVIDER_PROFILES } = await import("../../open-sse/config/constants.ts");
const { resolveResilienceSettings } = await import("../../src/lib/resilience/settings.ts");

const BODY = {
Expand Down Expand Up @@ -222,9 +223,13 @@ test("isPinnedTargetModelScopedUnusable distinguishes model lockout from provide
false
);

// Reset breaker, test provider cooldown
// Reset breaker, test provider cooldown. Since #12247 the global provider
// cooldown honors the PROVIDER_PROFILES window gate: the provider only counts
// as cooling after providerFailureThreshold failures inside the window.
cb.reset();
recordProviderCooldown("antigravity", undefined, resilienceSettings);
for (let i = 0; i < PROVIDER_PROFILES.oauth.providerFailureThreshold; i++) {
recordProviderCooldown("antigravity", undefined, resilienceSettings);
}
assert.equal(
await isPinnedTargetModelScopedUnusable({
target,
Expand Down
7 changes: 6 additions & 1 deletion tests/unit/native-codex-turn-pin-model-scoped-fallback.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ const {
} = await import("../../open-sse/services/combo/nativeCodexTurnPin.ts");
const { recordProviderCooldown, isProviderInCooldown, clearCooldownState } =
await import("../../open-sse/services/providerCooldownTracker.ts");
const { PROVIDER_PROFILES } = await import("../../open-sse/config/constants.ts");
const { getCircuitBreaker, resetAllCircuitBreakers } =
await import("../../src/shared/utils/circuitBreaker.ts");
const { resolveResilienceSettings } = await import("../../src/lib/resilience/settings.ts");
Expand Down Expand Up @@ -403,7 +404,11 @@ describe("Native Codex Turn Pin model-scoped fallback", () => {
allCombos: null,
});

recordProviderCooldown("antigravity", undefined, settings);
// #12247: the window gate needs providerFailureThreshold failures before
// the whole provider counts as cooling.
for (let i = 0; i < PROVIDER_PROFILES.oauth.providerFailureThreshold; i++) {
recordProviderCooldown("antigravity", undefined, settings);
}
assert.equal(isProviderInCooldown("antigravity", undefined, settings), true);

const attempted: string[] = [];
Expand Down