Repository navigation
feat(dashboard): orchestration canvas — unified model + snapshot hook (part 1/2) - #12156
Merged
Merged
Conversation
…s filter, overflow cap
…aleness (review r1)
…haned-runner tasks, true overview counts Addresses the final whole-branch review findings on the Orchestration Canvas model layer before merge: - mergeSnapshot: materialize the placeholder source node when a source status reports offline:true (not only !ok), so PR-2's SourceNode can actually reach the sublabel === "offline" render arm for an offline Conductor. - fromConductor: a running task can only be "absorbed" into a runner's ActivityNode when that runner id is present in snap.runners — a task whose runner deregistered mid-flight now emits as a normal work node instead of vanishing. - OrchNode gains an additive droppedByState field; mergeSnapshot stamps it on overflow nodes with the per-state counts of the work nodes the 40-node cap dropped, and overviewProjection folds it into counts (never columns) so the overview counters always show true totals per operator ruling. - Fixes the pre-first-poll 1970 generatedAt (lazy Date.now() seed for polledAt) and nulls debounceRef after clearTimeout in the poll effect's cleanup to avoid a StrictMode remount permanently swallowing WS triggers. - Prettier formatting pass on the touched model/hook/test files.
…or new-code complexity ratchets
Collaborator
Author
Collaborator
Author
This was referenced Sep 1, 2026
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
… (part 1/2) (cheaper-inference#12156) Modelo puro do Orchestration Canvas (tipos, 3 mappers, mergeSnapshot com dedupe/staleness/cap, projeções flow+overview) + hook de polling com gatilho WS. Ciclo completo: 9 tasks TDD com review por task, review final whole-branch + fixes verificados 6/6, refactor de complexity re-validado (comportamento preservado). CI: 18 pass. Testes: 31 node:test + 2 vitest. Parte 2/2 (UI /dashboard/orchestration) na sequência.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure domain model (OrchState/OrchNode) unifying Cloud Agent + A2A + Conductor + routing, plus the polling/WS-triggered snapshot hook. No UI yet — part 2 adds /dashboard/orchestration. Spec: _tasks (private). Tests: 3 node:test model suites + 1 vitest hook suite.