Repository navigation
fix(lint): pin react hooks plugin to 7.0.1 - #11886
Merged
diegosouzapw merged 1 commit intoAug 28, 2026
Merged
Conversation
eslint-config-next permits eslint-plugin-react-hooks updates through ^7.0.0, so a reused or refreshed node_modules could load 7.1.1 and change React Compiler diagnostics without a source change. Pin the analyzed version directly and guard its package/lockfile alignment with a regression test.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
Recreated from cheaper-inference#11749 (MumuTW) onto the active release/v3.8.51 — commit cherry-picked with author preserved; regression test + check:lockfile + check-file-size all green on this tip. Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recreation of #11749 (MumuTW) onto the active
release/v3.8.51— the original PR was openedagainst the stale
release/v3.8.50, and MumuTW's fork rejects maintainer pushes, so a directrebase-and-push wasn't possible. Cherry-picked the PR's single commit (author preserved) onto
the current tip and re-validated here.
Root cause
eslint-config-next allows eslint-plugin-react-hooks through ^7.0.0. A reused or refreshed
node_modules could therefore load 7.1.1 while the repository lockfile and source remained
unchanged. The 7.1 analyzer changes then surfaced hundreds of React Compiler diagnostics
across unrelated dashboard files.
Verification (on release/v3.8.51 tip)
node --import tsx/esm --test tests/unit/eslint-react-hooks-version-pinned.test.ts— passnpm run check:lockfile: passnode scripts/check/check-file-size.mjs: passCloses #11749 (recreated — commit author MumuTW preserved via cherry-pick).
Co-authored-by: MumuTW 42820974+MumuTW@users.noreply.github.com