Repository navigation
fix(db): skip absent compression telemetry cleanup table - #11802
Merged
diegosouzapw merged 3 commits intoAug 28, 2026
Merged
diegosouzapw merged 3 commits into
diegosouzapw merged 3 commits into
Conversation
diegosouzapw
merged commit Aug 28, 2026
a45e80a
into
cheaper-inference:release/v3.8.51
15 of 16 checks passed
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…erence#11802) Obrigado pela correção! Validado em lote combinado (8 PRs, release/v3.8.51): - Reprodução com imagem pública confirmada no corpo da PR (`compression_run_telemetry` ausente após fresh install). - Reutiliza o helper `tableExists()` já existente — sem SQL cru novo. - Testes focados: 7/7 em `tests/unit/telemetry-auto-cleanup-6848.test.ts` (verde). - Gates estáticos do lote: typecheck, lint (228 erros pré-existentes na tip pura, confirmado via probe-worktree — zero regressão), complexity, cognitive-complexity, file-size e changelog-integrity — todos OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compression_run_telemetrytable as empty during retention cleanup.tableExists()DB helper, so a fresh install no longer emits a non-fatal SQLite warning 30 seconds after startup.Public-image reproduction:
The current
release/v3.8.51source has the same lazy-only table initialization and cleanup ordering. Its public Docker publish run did not produce a new image because the arm64 build exhausted memory: https://github.com/diegosouzapw/OmniRoute/actions/runs/33041245780Related Issues
Validation
npm run lintRed-first proof:
Passed:
Tests Added Or Updated
tests/unit/telemetry-auto-cleanup-6848.test.tsdrops the lazy table and asserts cleanup returns an empty, error-free result.{ deleted: 0, errors: 1 }.Coverage Notes
The regressions execute the changed branches in
cleanupCompressionRunTelemetry()against isolated, real SQLite. The injected failure goes through the realtableExists()call, and the existing sibling test covers the table-present deletion path.Reviewer Notes
src/lib/db/compressionRunTelemetry.ts; the startup cleanup is the sole caller that can reach it first.src/lib/db/cleanup.ts; those lines are mechanical only.