Repository navigation
fix: regenerate package-lock.json for packages/browser-pool workspace - #11784
Merged
diegosouzapw merged 1 commit intoAug 30, 2026
Conversation
The packages/browser-pool workspace manifest (playwright@1.62.1,
@types/node@^26) was bumped without regenerating package-lock.json,
leaving stale nested overrides (playwright@1.61.1, @types/node@22.20.1)
that don't satisfy the workspace's own package.json specs.
Online installs masked this by silently re-resolving the mismatched
subtree, but cache-only/offline installs (npm ci --offline, Nix
buildNpmPackage, Docker builds with a pre-warmed lock cache) fail with
ENOTCACHED because Arborist correctly refuses the invalid locked
placement and tries to hit the registry for the real versions.
Removed the stale packages/browser-pool/node_modules/{playwright,
@types/node,undici-types} lock entries and regenerated via
'npm install --package-lock-only'. Both packages now hoist cleanly to
the already-correct root-level versions (playwright@1.62.1,
@types/node@26.2.0), so no nested override is needed at all.
Verified:
- npm install --ignore-scripts --cache /tmp/omniroute-cache (cache
warm-up): exit 0
- npm ci --ignore-scripts --cache /tmp/omniroute-cache --offline (full
monorepo, 2,434 packages): exit 0, no registry hits — this is the
exact cache-only reproduction from the issue
- playwright resolves to 1.62.1, @types/node resolves to 26.2.0, both
hoisted to root with no nested overrides under
packages/browser-pool/node_modules
Fixes cheaper-inference#11747
diegosouzapw
merged commit Aug 30, 2026
dfc84ba
into
cheaper-inference:release/v3.8.51
3 checks passed
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…cheaper-inference#11784) Regeneração legítima do `package-lock.json` do workspace `packages/browser-pool`. Sem alteração de código, validado no worktree combinado. Obrigado!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11747
Problem
packages/browser-pool/package.jsonrequiresplaywright@1.62.1and@types/node@^26, butpackage-lock.jsonretained stale nested overrides from before that manifest was bumped:playwright@1.61.1and@types/node@22.20.1. These don't satisfy the workspace's own specs, so Arborist treats the locked placement as invalid.Online
npm installmasks this by silently re-resolving the mismatched subtree. Cache-only/offline installs (npm ci --offline, Docker builds with a pre-warmed lock cache, Nix'sbuildNpmPackage) correctly refuse to trust the stale lock and try to hit the registry for the real versions — failing withENOTCACHEDwhen no network is available.Fix
Removed the stale
packages/browser-pool/node_modules/{playwright,@types/node,undici-types}entries frompackage-lock.jsonand regenerated withnpm install --package-lock-only. No nested override is needed at all — root already resolvesplaywright@1.62.1/@types/node@26.2.0, andbrowser-pool's ranges are compatible, so it now hoists cleanly to those.Scanned both workspaces (
open-sse,packages/browser-pool) for any other manifest/lockfile drift — none found; this was isolated to the one workspace.Diff
package-lock.json: 13 insertions, 98 deletions. No production code changed.Testing
npm ci --ignore-scripts --cache <cache> --offlineagainst a cache warmed exclusively from the corrected lockfile: exit 0, full monorepo (2,434 packages), no registry hits — this is the exact cache-only reproduction from the issueplaywrightresolves to1.62.1,@types/noderesolves to26.2.0, both hoisted to root with no nested overrides underpackages/browser-pool/node_modulesnpm run lint: exit 0, cleanChecklist
changelog.d/fixes/11747-browser-pool-lockfile-sync.md