Skip to content

chore(lint): drain remaining release base-reds - #11733

Merged
diegosouzapw merged 8 commits into
release/v3.8.51from
chore/v3851-prune-stale-eslint-suppressions-2
Aug 27, 2026
Merged

diegosouzapw merged 8 commits into
release/v3.8.51from
chore/v3851-prune-stale-eslint-suppressions-2

Conversation

@diegosouzapw

@diegosouzapw diegosouzapw commented Aug 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • prune two stale ESLint suppressions and make the affected hook test obey react-hooks/globals
  • synchronize the generated omni-inference skill and the measured 357-provider documentation mirrors
  • remove the invalid AnySearch Lobe icon alias so the existing initial-letter fallback is used instead of crashing
  • rebaseline the measured CLI bundle growth introduced by fix(cli): flag a .env that lives inside the installed package #11437, while keeping the ratchet direction blocking
  • drain the remaining inherited mutation-coverage, expiring-fixture, and provider-golden base reds

Refs #11449.

Exact-base attribution

Release base: 2e8326d5314f171af0d379d8f2900970325a4085.

  • ESLint reproduced the two stale suppressions and then exposed the masked react-hooks/globals error. Base log: status 1, SHA-256 d932aa8b7fc4977fb632e00ff140a8e0a49b2fed66e6229cc877c7fd262312d7.
  • check:agent-skills-sync failed on both the exact base and pre-sync candidate with byte-identical logs, SHA-256 5679595d603b196fbfd61495d3b194625f9252ccca322fb5cd8783b6b056a86e.
  • check:docs-all failed on both the exact base and pre-doc candidate with byte-identical logs, SHA-256 6fa9d36fd7a4bada0e38b1889e866fb12850abc3967bba6c9e6b580336640698.
  • Dashboard typecheck and bundle-size logs were byte-identical on the exact base and pre-fix candidate: SHA-256 62f31c8f6cf1aba65ac279e86c6a5ac1d938da85f18a6c96d0f0d5ca177eafec and 7736b0b3be09801a0d5120cfc88c371506720601938dec25c72fd3a8366d9395, respectively.
  • The mutation-coverage gate failed on base and candidate with byte-identical logs, status 1 and SHA-256 c75ed731b6970d457cfd927262922411c29fa63762c13255e5c98cbf92858b22: combo-rr-diagnostics-11462.test.ts was missing from Stryker's TAP inventory.
  • The same three unit failures reproduced on base and candidate: the Alibaba pack test, executors/dispatch-rules, and provider/translate-path. Base log SHA-256: 5d72b9eefbca54214c274863fdb7f54b461e1e419c6fde717a2ae01d69e863fc; pre-fix candidate log SHA-256: 69cad0d5fb4e4c8b24772e73a29906e5e268f782934523b50533075b9521c3f0.

These failures were inherited from the release tip and were kept out of the Video Bridge feature branch.

Runtime and test fixes

  • AnySearch is not exported by @lobehub/icons; resolving that impossible alias produced a runtime TypeError. The alias is removed and ProviderIcon now reaches its existing initial-letter fallback.
  • The Alibaba test no longer treats the dated canonical pack as permanently valid. It uses an isolated, non-expiring temporary pack and restores the environment/cache in finally; production expiry and embedded fallback behavior are unchanged.
  • The executor golden is deterministically key-sorted, and the provider golden now records the already-active codex-cli/0.149.0 user agent.

Bundle rebaseline

Paired VPS measurements against the last measured baseline commit f95b03d70929a6a850d4b986a7bbad6740dd02e0 showed:

  • baseline: CLI 4700 + MCP 1195 + node runtime 983 + reset 1583 = 8461 bytes
  • current: CLI 4892 + MCP 1195 + node runtime 983 + reset 1583 = 8653 bytes

The 192-byte increase is isolated to the CLI entry and traces to #11437. The CLI remains 4892/15000 bytes (32.6% of its cap); decreases remain blocking, and only the measured ceiling was updated.

RED to GREEN evidence

Authoritative host: root@192.168.0.15
Final candidate: 21ed68d8ac0902d2208083f7ee3d615d64aad502

  • AnySearch RED (12cc6ca834): 2/2 failed with the runtime TypeError; log SHA-256 f565d8fcd02544a3217e6f741f1e73218b8473037071af874ed25c2c8ba2ab1f.
  • AnySearch GREEN (9587e07b69): 2/2 passed; log SHA-256 e4b241c05ef448f419ac838a5480d398310858d3b2047c5b00986013319ec6d3.
  • Final mutation gate: PASS, no drift; log SHA-256 3d7e293a932c8778bbbd0e0aa50b1f83d8bfb55524f5f1340e5ce9fe0073410c.
  • Final focused inherited-red suite: PASS, 7/7; log SHA-256 0a4ee42d28e9b92fbbe748cbd0a53d7dbde167d3043b211d745c872081bdefef.
  • check:release-green -- --quick --full-ci --hermetic: RELEASE-GREEN, 0 hard failures, 0 drift, status 0; log SHA-256 51e24dcad36a60c4b2d343e50413f863894e4239c1fb2708ea45edb414f5717c.
  • GitHub Quality Gates run 33037266560: all applicable jobs passed. The formerly red shard passed 9170/9171 with 1 expected skip, plus 47/47 dashboard and 11/11 serial tests.
  • Fast Production Build, DAST, CodeQL, Semgrep, docs, Vitest, all four unit shards, merge integrity, and the ESLint ratchet are green on the exact final head.

@diegosouzapw
diegosouzapw merged commit c9f11d8 into release/v3.8.51 Aug 27, 2026
22 checks passed

@RaviTharuma RaviTharuma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against release/v3.8.51 base-red evidence. This keeps the fix mechanical and centralized: stale ESLint suppressions are pruned, the exposed hook test violation is corrected, generated AnySearch skill output is synced, and all 357-provider docs/mirrors are updated. CI is fully green, including build, CodeQL, DAST, Semgrep, merge integrity, docs, lint, quality gates, and all unit shards. This is the correct base repair before rebasing feature PRs #11710 and #11727.

@RaviTharuma RaviTharuma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against release/v3.8.51 at 2e8326d and head 21ed68d. The changes directly drain the reproduced base-reds: stale ESLint suppressions, generated omni-inference docs, provider-count mirrors, deterministic AnySearch icon fallback with regression coverage, measured quality baseline drift, and inherited shard-1 goldens/fixture handling. Diff check is clean. Current CI is fully green: Quality Gates 33037266560 passes merge integrity, ESLint, docs, Fast Quality, Vitest, and all four unit shards; DAST, Semgrep, Build App, and CodeQL also pass. No feature-PR changes are mixed in.

muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…851-prune-stale-eslint-suppressions-2

chore(lint): drain remaining release base-reds
@diegosouzapw
diegosouzapw deleted the chore/v3851-prune-stale-eslint-suppressions-2 branch October 18, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants