Repository navigation
fix(dashboard): replace unprovenanced notification MP3 - #11731
Merged
diegosouzapw merged 3 commits intoAug 28, 2026
Merged
Conversation
diegosouzapw
force-pushed
the
fix/v3850-replace-unlicensed-notify-audio
branch
from
August 28, 2026 03:57
87ecda6 to
1112290
Compare
diegosouzapw
marked this pull request as ready for review
August 28, 2026 07:34
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…ence#11731) Merged via /merge-batch (v3.8.51 provenance sweep). Boarded and validated together with the batch's other provenance/asset-cleanup PRs in a combined worktree — full gate suite green. Static-asset-only cleanup, no runtime code changes. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
public/audio/ui-notify.mp3, whose origin and license could not be establishedAudioContextonly from the toggle gesture, resumes suspended contexts, fails open when Web Audio is unavailable or rejected, and closes the context when the card unmountsEvidence and status
4a716f2a47d4fa230840e14ecc96965ba6be05c62c1cafa9e6f7c540e458a42f); Git history remains recoverable from base0915890if an audit needs the original bytes./audio/ui-notify.mp3reference and the regression guard verifies both the file and component reference remain absent.Audioasset playback is not called.TDD evidence
npm exec -- vitest run --config vitest.config.ts tests/unit/ui/model-lockout-notify-chime.test.tsx→ 2 failed / 2 while the MP3 still existed and the generated-feedback contract was unmet.npm run test:vitest:ui -- tests/unit/ui/model-lockout-notify-chime.test.tsx→ 6 passed / 6.Additional validation
npm run typecheck:coregit diff --checkThis PR is intentionally draft/open. It does not merge, tag, publish, release, or deploy anything.
Independent review follow-up
87ecda603b.AudioContext, two synthesized oscillators, the 880 Hz / 100 ms envelope, oscillator-to-gain-to-destination wiring, per-note node cleanup, and thewebkitAudioContextfallback.