Repository navigation
chore(stryker): register the two test files covering three mutated modules - #11577
Merged
diegosouzapw merged 2 commits intoAug 26, 2026
Conversation
…dules
`check:mutation-test-coverage --strict` — a Fast Quality Gates sub-check — fails on
every branch:
✗ 3 covering unit test(s) across 3 module(s) are missing from
stryker.conf.json tap.testFiles.
src/server/authz/routeGuard.ts
+ tests/unit/authz/route-guard-tunnel-processes-local-only.test.ts
open-sse/services/combo/quotaScoring.ts
+ tests/unit/universal-quota-aware-routing.test.ts
open-sse/services/combo/quotaStrategies.ts
+ tests/unit/universal-quota-aware-routing.test.ts
All three modules are in `mutate`; both test files exist and import the module they
are credited with. `tap.testFiles` is the explicit set Stryker runs, so a covering
test outside it means its mutant kills are not counted — the three modules score
lower than the suite actually earns.
Adds both paths in their sorted positions. Config-only.
This was referenced Aug 26, 2026
diegosouzapw
merged commit Aug 26, 2026
5c1a882
into
cheaper-inference:release/v3.8.51
10 of 16 checks passed
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…dules (cheaper-inference#11577) Merged via /merge-batch (lote 2026-08-26, v3.8.51). Boarded no worktree combinado junto com outras ~30 PRs; validação única: typecheck/complexity/cognitive-complexity/changelog-integrity verdes, file-size rebaseado onde necessário (crescimento legítimo), lint com os mesmos 228 achados pré-existentes confirmados via sonda contra o tip puro (não introduzidos por este lote), e ~370 testes focados (unit + vitest) passando. Obrigado pela contribuição.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gate
Fast Quality Gatesfails on every branch. One of its two failing sub-checks ischeck:mutation-test-coverage --strict(job):
Two test files, three module credits.
Why it matters beyond the red X
tap.testFilesis the explicit set Stryker runs — the file's own comment says so. Atest that covers a mutated module but sits outside that set contributes no mutant
kills, so the module's score understates what the suite already proves. Both of these
are recent additions whose authors had no reason to know about the list.
Verification
The gate's own inputs, read straight out of the repo:
mutatecontainssrc/server/authz/routeGuard.ts,open-sse/services/combo/quotaScoring.ts,open-sse/services/combo/quotaStrategies.ts— alltruetests/unit/authz/route-guard-tunnel-processes-local-only.test.ts(2.2K),tests/unit/universal-quota-aware-routing.test.ts(7.9K)LOCAL_ONLY_API_GET_EXEMPTIONS,LOCAL_ONLY_API_PREFIXES,isLocalOnlyPathfromrouteGuard.ts; the second doesawait import("../../open-sse/services/combo/quotaScoring.ts")and.../quotaStrategies.tson lines 7–8tap.testFiles.includes(...)→falsefor both, before;truefor both, afteraihorde-optional-api-key.test.ts) and the pre-existingprettier --checkcomplaint on this file are unchanged, and I left both alone as out of scopeBoth paths are inserted in their sorted positions, matching the rest of the list.
A note on how I confirmed this:
node scripts/check/check-mutation-test-coverage.mjs --strictexits 0 on my Windows host while CI exits 1, so the scanner appears tomis-resolve paths on win32 — the same class of separator bug as elsewhere in this repo.
I did not chase it here; the config drift above is verified directly against
stryker.conf.jsonand the two test files rather than through the scanner. Happy toopen a separate issue for the win32 false-pass if that is useful, since it means a
Windows contributor cannot see this gate fail before pushing.
Config-only: no code, no tests, no behaviour change.