Skip to content

fix: restore live websocket URL helpers - #11509

Merged
diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.51from
PauloFH:fix/live-ws-url-helpers
Aug 26, 2026
Merged

diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.51from
PauloFH:fix/live-ws-url-helpers

Conversation

@PauloFH

@PauloFH PauloFH commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Validation

  • live-ws-url-11331: 11/11 passing
  • Prettier check: passing
  • ESLint for wsPath.ts: passing
  • typecheck:core: passing
  • full production build deferred to CI because the local machine ran out of resources

@PauloFH
PauloFH requested a review from diegosouzapw as a code owner August 25, 2026 12:20
Copilot AI lite review requested due to automatic review settings August 25, 2026 12:20
@PauloFH

PauloFH commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@diegosouzapw this one-commit fix restores the helpers omitted during the #11388 squash and unblocks the Turbopack failures on release PR #11442. GitHub is requiring maintainer approval before the fork workflows can run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The PR description does not include a passing npm run test:coverage result (required gate), so approval should wait for that confirmation (CI or author-run).

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Restores the live WebSocket URL helper utilities in src/shared/utils/wsPath.ts, unblocking existing client imports (notably Turbopack) and re-establishing the handshake-driven runtime port/path resolution needed for prebuilt images.

Changes:

  • Re-introduces sanitizeLiveWsPort() to safely accept only integer ports in the 1–65535 range.
  • Re-introduces resolveLiveWsUrl() to apply handshake-reported publicUrl / port / path onto the compiled-in default URL with clear precedence rules.
  • Keeps behavior aligned with the existing regression test suite (tests/unit/live-ws-url-11331.test.ts) that imports and exercises these helpers.
File summaries
File Description
src/shared/utils/wsPath.ts Restores missing live WS URL helpers so the dashboard can honor handshake-reported port/path and existing imports no longer fail.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@diegosouzapw
diegosouzapw merged commit 7a10d38 into cheaper-inference:release/v3.8.51 Aug 26, 2026
3 checks passed
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
Merged via /merge-batch (lote 2026-08-26 batch 2, v3.8.51). Boarded no worktree combinado junto com outras ~20 PRs; validação única: typecheck/complexity/cognitive-complexity/changelog-integrity verdes, file-size rebaseado onde necessário (crescimento legítimo), lint com os mesmos 228 achados pré-existentes confirmados via sonda contra o tip puro (não introduzidos por este lote), e 292 testes focados (unit) + 18 (vitest) passando. Obrigado pela contribuição.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants