Repository navigation
fix(kie): map remaining google-imagen Market ids to their real KIE upstream ids - #11326
Merged
diegosouzapw merged 2 commits intoAug 24, 2026
Merged
Conversation
…stream ids Issue #11225's fix only mapped google-imagen/nano-banana-2 -> nano-banana-2. Per docs.kie.ai/market/google/*, the other three google-imagen Market catalog ids also need an explicit upstream mapping, and it is not a uniform "strip the namespace" rule: - google-imagen/nano-banana -> google/nano-banana - google-imagen/nano-banana-pro -> nano-banana-pro - google-imagen/nano-banana-edit -> google/nano-banana-edit Verified against the other 27 KIE Market catalog ids (seedream, flux, ideogram, qwen, wan, grok-imagine, gpt): their catalog ids already match their real upstream ids byte-for-byte, so KIE_MARKET_UPSTREAM_MODEL_IDS stays scoped to the google-imagen namespace. Refs #11296
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…stream ids (cheaper-inference#11326) Merging --admin with red discrimination (merge-gates §4). Fails: ESLint warnings ratchet drift (inherited base-red), Unit Tests shards containing stream-timing.test.ts (CPU-contention timing flake, assert.ok(total >= 15)ms — unrelated to this PR's scope, open-sse/handlers/imageGeneration.ts), and dast-smoke (advisory, isRequired:null).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #11225 (fixed by #11231) mapped exactly one KIE Market catalog id to its real upstream id:
google-imagen/nano-banana-2→nano-banana-2. The reporter of #11296 said this did not fix the "whole catalog" and asked that the other Market models be checked.Investigation against the official docs (
docs.kie.ai/market/google/*) confirms three moregoogle-imagen/*ids in our catalog need the same kind of explicit mapping, and the KIE upstream naming is not a uniform "strip the namespace" rule:modelvaluegoogle-imagen/nano-bananagoogle/nano-bananagoogle-imagen/nano-banana-2nano-banana-2(already fixed in #11231)google-imagen/nano-banana-pronano-banana-progoogle-imagen/nano-banana-editgoogle/nano-banana-editThe other 27 Market catalog ids (
seedream/*,flux/*,ideogram/*,qwen*/*,wan/*,grok-imagine/*,gpt/*) were cross-checked against docs.kie.ai and already match their real upstream ids byte-for-byte, so this PR keepsKIE_MARKET_UPSTREAM_MODEL_IDSscoped to thegoogle-imagennamespace rather than adding a generic namespace-stripping rule that could silently break those other 27 models.Test plan
tests/unit/kie-market-upstream-model-id-11225.test.tswith the failing assertions first (RED), confirmed against docs.kie.ai, then implemented the mapping (GREEN).node --import tsx/esm --test tests/unit/kie-market-upstream-model-id-11225.test.ts— 10/10 passing, including new createTask-payload assertions for all 3 new ids and the existing seedream control (byte-identical, unaffected).npm run typecheck:core— clean.npm run lint— exit 0 (0 new violations against the suppressions gate).Refs #11296