Repository navigation
Conversation
rqzbeh
force-pushed
the
fix/mcp-web-search-provider-enum-dynamic
branch
from
August 22, 2026 14:54
d4b39b6 to
0aeb0de
Compare
…egram, and Discord formatters (cheaper-inference#9985)
rqzbeh
force-pushed
the
fix/mcp-web-search-provider-enum-dynamic
branch
from
August 22, 2026 15:05
0aeb0de to
5d4a6c3
Compare
Collaborator
|
Closing with credit — verified subsumed against the current tip:
Remaining known gap (filed mentally as backlog): the MCP enum is built statically at module scope, so runtime-blocked providers still appear in the schema — a real fix needs runtime-schema plumbing, which is a separate design. Thank you @rqzbeh — the endpoint half of #11100 landed through your #11125! |
diegosouzapw
pushed a commit
that referenced
this pull request
Aug 22, 2026
… providers (#11100) (#11155) Cherry-picked onto the current tip (authorship preserved), generated-count noise stripped. Two pre-merge adjustments: (1) dropped the unrelated localDb.ts re-export hunk (nothing in this PR uses those symbols); (2) automated security review flagged the blocked-provider list resolving once at server creation — the handler now rebuilds the schema per invocation via the resolver (advertised tools/list schema stays a creation-time snapshot, which is inherent to MCP). Vitest: new runtime-blocked-schema suite 3/3, full MCP __tests__ 118/118; contract suites (mcp-web-search-provider-enum-contract, search-blocked-providers-11100) 6/6; typecheck clean. This closes the residual gap noted when #11120 was closed. Thank you @rqzbeh!
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
… providers (cheaper-inference#11100) (cheaper-inference#11155) Cherry-picked onto the current tip (authorship preserved), generated-count noise stripped. Two pre-merge adjustments: (1) dropped the unrelated localDb.ts re-export hunk (nothing in this PR uses those symbols); (2) automated security review flagged the blocked-provider list resolving once at server creation — the handler now rebuilds the schema per invocation via the resolver (advertised tools/list schema stays a creation-time snapshot, which is inherent to MCP). Vitest: new runtime-blocked-schema suite 3/3, full MCP __tests__ 118/118; contract suites (mcp-web-search-provider-enum-contract, search-blocked-providers-11100) 6/6; typecheck clean. This closes the residual gap noted when cheaper-inference#11120 was closed. Thank you @rqzbeh!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11100.
Summary
omniroute_web_searchMCP tool'swebSearchInputschema withz.enum(getActiveSearchProviders()).getActiveSearchProviders(blockedProviders?: string[])toopen-sse/config/searchRegistry.ts, which dynamically returns active registered search provider IDs and filters out any disabled or blocked providers (viaisProviderBlockedByIdOrAlias).handleWebSearchinopen-sse/mcp-server/server.tssignature to acceptprovider?: string.tests/unit/mcp-web-search-provider-enum-contract.test.ts.