Repository navigation
fix(logs): apply filter predicates to merged in-memory call-log rows - #11082
Merged
diegosouzapw merged 1 commit intoAug 22, 2026
Conversation
diegosouzapw
merged commit Aug 22, 2026
80d931a
into
cheaper-inference:release/v3.8.50
9 of 16 checks passed
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…heaper-inference#11082) Validated on a combined board over tip c2d6247 (incl. sibling cheaper-inference#11081): call-logs-row-filter 4/4 green, typecheck:core clean. The merged-row predicate fix closes a real gap — in-memory (in-flight/recently-completed) rows bypassed every filter except correlationId; rowMatchesFilter() now applies search/model/provider/account/apiKey/status/combo uniformly while DB rows stay idempotent. Thank you @AndrianBalanescu!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCallLogs()filters persisted database rows server-side, but in-memory rows (in-flight active requests and recently completed items from the runtime buffer) are merged in viabuildCallLogListRows().correlationIdwas filtered after merging, allowing active/completed in-memory rows to bypass filters likesearch,model,provider,account,apiKey,status, andcombo.rowMatchesFilter()over the merged result set, correctly filtering in-memory items while preserving DB results idempotently.tests/unit/call-logs-row-filter.test.ts.Testing
node --import tsx/esm --test tests/unit/call-logs-row-filter.test.tspasses (4/4).