Skip to content

fix(providers): remove ALLOW_MULTI_CONNECTIONS_PER_COMPAT_NODE, a no-op flag - #10974

Merged
diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.50from
maxmad64bis:fix/dead-flag-multi-connections-per-compat-node
Aug 21, 2026
Merged

diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.50from
maxmad64bis:fix/dead-flag-multi-connections-per-compat-node

Conversation

@maxmad64bis

@maxmad64bis maxmad64bis commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

ALLOW_MULTI_CONNECTIONS_PER_COMPAT_NODE looks like it gates multi-connection support
for compat providers, but nothing checks it anymore. Traced the history: it did govern
real behavior at launch (v1.0.0) — a single-connection guard in route.ts. Commit
5b5e21a99 (fix: resolve v3.7.0 stabilization issues, closing #1566 — "OpenAI
Compatible node: support multiple connections") deliberately removed that guard so
compat providers behave like first-party ones, but left the env-var read
(allowMultipleCompatibleConnections) and the matching Settings flag definition behind.
Toggling this flag today does nothing. Removed the flag definition and the dead read,
without wiring it up to gate anything again — that would reverse #1566's decision, which
is a separate call from a dead-code cleanup.

⚠️ base-red inherited: #9985

Related Issues

Cleans up dead code left over from #1566 (resolved by 5b5e21a99). No new issue.

Validation

  • Change type: other (dead-code removal, zero behavior change)
  • Focused tests: feature-flags-settings.test.ts
  • npm run lint
  • No behavior changed — the updated flag-count assertion is the regression guard

Tests Added Or Updated

tests/unit/feature-flags-settings.test.ts — EXPECTED_FEATURE_FLAG_COUNT decremented
by 1 to match the removed definition. The other assertions reference the constant by
name, so they didn't need touching.

Coverage Notes

Covered by that same count assertion — it's the exact regression guard for "a flag got
removed".

Reviewer Notes

The flag's i18n key (featureFlagAllowMultiConnectionsPerCompatNodeDescription) only had
one reference — its own declaration — so no locale files needed touching there. Separately,
src/i18n/messages/*.json (20 locales) still carries an older, differently-named
featureFlags.definitions.ALLOW_MULTI_CONNECTIONS_PER_COMPAT_NODE entry that predates
this PR and isn't wired to anything either — left alone here since it's a different
cleanup (i18n message catalog vs. flag definition), happy to follow up separately if
useful. Also removed the matching doc references (.env.example,
docs/architecture/ARCHITECTURE.md, docs/reference/ENVIRONMENT.md,
docs/reference/FEATURE_FLAGS.md). See #10973 for the sibling cleanup — the
existingConnections variable the removed guard also read is dead for the same reason,
from the same 5b5e21a99 commit, split into its own PR since it doesn't touch a Settings
surface.

@maxmad64bis
maxmad64bis force-pushed the fix/dead-flag-multi-connections-per-compat-node branch from 4d40456 to 5af77fe Compare August 21, 2026 13:54
@diegosouzapw
diegosouzapw merged commit 464ccb3 into cheaper-inference:release/v3.8.50 Aug 21, 2026
7 of 16 checks passed
diegosouzapw pushed a commit that referenced this pull request Aug 21, 2026
… creation (#10973)

⭐5 — Remove leitura morta de existingConnections em route.ts, resíduo do mesmo commit 5b5e21a que já removeu o guard que a usava (#1566). Zero comportamento alterado, 14/14 testes-irmãos verdes. Sibling de #10974.
Sa3id23 pushed a commit to Sa3id23/OmniRoute that referenced this pull request Aug 21, 2026
…g that governs nothing (cheaper-inference#10974)

⭐5 — Remove ALLOW_MULTI_CONNECTIONS_PER_COMPAT_NODE, flag morta desde 5b5e21a (que removeu o guard que a lia, resolvendo cheaper-inference#1566). Zero mudança de comportamento; EXPECTED_FEATURE_FLAG_COUNT é o regression guard. Sibling de cheaper-inference#10973 (mesma raiz).
Sa3id23 pushed a commit to Sa3id23/OmniRoute that referenced this pull request Aug 21, 2026
… creation (cheaper-inference#10973)

⭐5 — Remove leitura morta de existingConnections em route.ts, resíduo do mesmo commit 5b5e21a que já removeu o guard que a usava (cheaper-inference#1566). Zero comportamento alterado, 14/14 testes-irmãos verdes. Sibling de cheaper-inference#10974.
@maxmad64bis
maxmad64bis deleted the fix/dead-flag-multi-connections-per-compat-node branch September 24, 2026 21:13
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…g that governs nothing (cheaper-inference#10974)

⭐5 — Remove ALLOW_MULTI_CONNECTIONS_PER_COMPAT_NODE, flag morta desde dd1db47 (que removeu o guard que a lia, resolvendo cheaper-inference#1566). Zero mudança de comportamento; EXPECTED_FEATURE_FLAG_COUNT é o regression guard. Sibling de cheaper-inference#10973 (mesma raiz).
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
… creation (cheaper-inference#10973)

⭐5 — Remove leitura morta de existingConnections em route.ts, resíduo do mesmo commit dd1db47 que já removeu o guard que a usava (cheaper-inference#1566). Zero comportamento alterado, 14/14 testes-irmãos verdes. Sibling de cheaper-inference#10974.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants