Repository navigation
fix(providers): remove ALLOW_MULTI_CONNECTIONS_PER_COMPAT_NODE, a no-op flag - #10974
Merged
diegosouzapw merged 1 commit intoAug 21, 2026
Conversation
maxmad64bis
force-pushed
the
fix/dead-flag-multi-connections-per-compat-node
branch
from
August 21, 2026 13:12
a13ec3f to
4d40456
Compare
4 tasks done
…g that governs nothing
maxmad64bis
force-pushed
the
fix/dead-flag-multi-connections-per-compat-node
branch
from
August 21, 2026 13:54
4d40456 to
5af77fe
Compare
diegosouzapw
merged commit Aug 21, 2026
464ccb3
into
cheaper-inference:release/v3.8.50
7 of 16 checks passed
Sa3id23
pushed a commit
to Sa3id23/OmniRoute
that referenced
this pull request
Aug 21, 2026
…g that governs nothing (cheaper-inference#10974) ⭐5 — Remove ALLOW_MULTI_CONNECTIONS_PER_COMPAT_NODE, flag morta desde 5b5e21a (que removeu o guard que a lia, resolvendo cheaper-inference#1566). Zero mudança de comportamento; EXPECTED_FEATURE_FLAG_COUNT é o regression guard. Sibling de cheaper-inference#10973 (mesma raiz).
Sa3id23
pushed a commit
to Sa3id23/OmniRoute
that referenced
this pull request
Aug 21, 2026
… creation (cheaper-inference#10973) ⭐5 — Remove leitura morta de existingConnections em route.ts, resíduo do mesmo commit 5b5e21a que já removeu o guard que a usava (cheaper-inference#1566). Zero comportamento alterado, 14/14 testes-irmãos verdes. Sibling de cheaper-inference#10974.
maxmad64bis
deleted the
fix/dead-flag-multi-connections-per-compat-node
branch
September 24, 2026 21:13
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…g that governs nothing (cheaper-inference#10974) ⭐5 — Remove ALLOW_MULTI_CONNECTIONS_PER_COMPAT_NODE, flag morta desde dd1db47 (que removeu o guard que a lia, resolvendo cheaper-inference#1566). Zero mudança de comportamento; EXPECTED_FEATURE_FLAG_COUNT é o regression guard. Sibling de cheaper-inference#10973 (mesma raiz).
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
… creation (cheaper-inference#10973) ⭐5 — Remove leitura morta de existingConnections em route.ts, resíduo do mesmo commit dd1db47 que já removeu o guard que a usava (cheaper-inference#1566). Zero comportamento alterado, 14/14 testes-irmãos verdes. Sibling de cheaper-inference#10974.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ALLOW_MULTI_CONNECTIONS_PER_COMPAT_NODElooks like it gates multi-connection supportfor compat providers, but nothing checks it anymore. Traced the history: it did govern
real behavior at launch (v1.0.0) — a single-connection guard in
route.ts. Commit5b5e21a99(fix: resolve v3.7.0 stabilization issues, closing #1566 — "OpenAICompatible node: support multiple connections") deliberately removed that guard so
compat providers behave like first-party ones, but left the env-var read
(
allowMultipleCompatibleConnections) and the matching Settings flag definition behind.Toggling this flag today does nothing. Removed the flag definition and the dead read,
without wiring it up to gate anything again — that would reverse #1566's decision, which
is a separate call from a dead-code cleanup.
Related Issues
Cleans up dead code left over from #1566 (resolved by
5b5e21a99). No new issue.Validation
feature-flags-settings.test.tsnpm run lintTests Added Or Updated
tests/unit/feature-flags-settings.test.ts—EXPECTED_FEATURE_FLAG_COUNTdecrementedby 1 to match the removed definition. The other assertions reference the constant by
name, so they didn't need touching.
Coverage Notes
Covered by that same count assertion — it's the exact regression guard for "a flag got
removed".
Reviewer Notes
The flag's i18n key (
featureFlagAllowMultiConnectionsPerCompatNodeDescription) only hadone reference — its own declaration — so no locale files needed touching there. Separately,
src/i18n/messages/*.json(20 locales) still carries an older, differently-namedfeatureFlags.definitions.ALLOW_MULTI_CONNECTIONS_PER_COMPAT_NODEentry that predatesthis PR and isn't wired to anything either — left alone here since it's a different
cleanup (i18n message catalog vs. flag definition), happy to follow up separately if
useful. Also removed the matching doc references (
.env.example,docs/architecture/ARCHITECTURE.md,docs/reference/ENVIRONMENT.md,docs/reference/FEATURE_FLAGS.md). See #10973 for the sibling cleanup — theexistingConnectionsvariable the removed guard also read is dead for the same reason,from the same
5b5e21a99commit, split into its own PR since it doesn't touch a Settingssurface.