[arminanton]

Summary

The official diegosouzapw/omniroute:next Docker image crashes immediately on boot with:

file:///app/server.js:1
const path = require('path')
             ^
ReferenceError: require is not defined in ES module scope

This is a CommonJS/ESM module-system conflict in the build, and it is a regression introduced by #10836. This PR fixes it at the source so the standalone server.js boots while the ESM worker bundles keep working.

Fixes #10933.

Root cause

Two build steps make contradictory claims about the standalone package.json:

1. scripts/build/assembleStandalone.mjs → patchStandalonePackageJson() removes "type":"module" from the standalone root package.json, on purpose, because the Next.js standalone entrypoint server.js is CommonJS (require(), __dirname).
2. scripts/build/colocate-standalone.mjs (the npm postbuild hook, added in fix(build): ensure standalone package.json declares module type for Node 24 worker compatibility #10836) re-adds "type":"module" to that same root so its esbuild'd ESM worker bundles (callLogArtifactWorker.js, onnxWorker.js, both emitted with --format=esm) load as ESM.

postbuild runs after build, so step 2 wins. The standalone root ends up with "type":"module", Node then parses the CommonJS server.js as ESM, and it throws on the first require(). run-standalone.mjs → server-ws.mjs → await import("./server.js") surfaces the crash at boot.

Fix

Node resolves a file's module system from the nearest package.json. Instead of flipping the whole standalone tree to ESM (which breaks server.js), scope {"type":"module"} to each worker's own directory:

• standalone root package.json → stays CommonJS (no type), so server.js runs
• src/lib/usage/package.json → {"type":"module"}, so callLogArtifactWorker.js runs as ESM
• open-sse/services/compression/engines/llmlingua/package.json → {"type":"module"}, so onnxWorker.js runs as ESM (only when the optional SLM deps are installed)

This preserves #10836's intent (the ESM workers still load without a warning) while keeping server.js CommonJS. No worker format change, no root edit. The write is no-clobber, so it never overwrites a package.json that Next's trace already placed in a worker directory.

The issue suggested renaming server.js → server.cjs; that works too, but it touches the Next standalone entry contract (server-ws.mjs, run-standalone.mjs, dev/run-standalone.mjs) and several build/pack scripts. Scoping the worker dirs is the smaller, more contained change and leaves the entrypoint untouched.

Changes

• scripts/build/colocate-standalone.mjs
  • Replace the root type:module re-add with writeEsmWorkerScopes(), which writes a scoped {"type":"module"} into each worker directory.
  • Refactor the script body into main() + an exported writeEsmWorkerScopes() helper, guarded by the import.meta.url === argv[1] run-check (same idiom as build-next-isolated.mjs), so the scoping logic is importable and unit-testable without a full next build.
  • Add an OMNIROUTE_STANDALONE_DIR override seam (mirrors write-build-sha.mjs / write-build-base-path.mjs).
• tests/unit/build/colocate-standalone-esm-scope.test.ts (new)
  • Asserts scoped type:module lands in each worker dir, the root package.json is never touched, and the write is no-clobber.
  • End-to-end guard: actually runs a CommonJS server.js and an ESM worker.js side by side under the scoped layout to prove the two module systems coexist (this is exactly what the bug broke).

Testing

$ node --import tsx/esm --test tests/unit/build/colocate-standalone-esm-scope.test.ts
# tests 4
# pass 4
# fail 0

Sibling build tests stay green (tests/unit/build/assemble-standalone.test.ts, tests/unit/colocate-optionals.test.ts: 13/13). I also rebuilt the runner-base image from this branch and confirmed the container boots past the previous crash and serves the dashboard.

Notes

• Base branch is release/v3.8.50 per CONTRIBUTING.md.
• Changelog fragment added under changelog.d/fixes/.

[Copilot]

Pull request overview

Fixes a Docker boot regression where the Next.js standalone server.js (CommonJS) was being parsed as ESM due to "type":"module" being re-added to the standalone root package.json during postbuild. The fix scopes {"type":"module"} to the specific worker directories so ESM worker bundles load correctly without forcing the entire standalone tree into ESM.

Changes:

• Refactors scripts/build/colocate-standalone.mjs to write per-worker package.json ESM scopes (writeEsmWorkerScopes) instead of mutating the standalone root manifest.
• Adds an OMNIROUTE_STANDALONE_DIR override seam and makes the script importable for unit testing (entrypoint guard + exported helper).
• Adds a focused unit/regression test that proves CJS server.js and ESM worker .js can coexist via nearest-package.json resolution.

Testing / Coverage (custom):

• Commands (reported in PR): node --import tsx/esm --test tests/unit/build/colocate-standalone-esm-scope.test.ts
• Changed/added tests: tests/unit/build/colocate-standalone-esm-scope.test.ts
• Coverage result: not provided in the PR description (custom)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
scripts/build/colocate-standalone.mjs	Stops re-adding "type":"module" at the standalone root; instead writes no-clobber ESM scopes in worker directories and adds a test seam/entry guard.
tests/unit/build/colocate-standalone-esm-scope.test.ts	New regression test covering scoped ESM manifests, no root mutation, no-clobber behavior, and an end-to-end CJS+ESM coexistence check.
changelog.d/fixes/10936-standalone-server-cjs-esm-scope.md	Changelog entry documenting the Docker boot crash fix and the worker-dir scoping approach.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.