Repository navigation
fix(images): route bare dall-e-3 to OpenAI - #10847
diegosouzapw merged 1 commit into
Conversation
d50d41f to
87ede03
Compare
|
Rebased onto current release/v3.8.50 via #10828 ( |
87ede03 to
a492e73
Compare
a492e73 to
a93def3
Compare
|
Rebased onto current #10828 (8f4cced43). Unique image-routing commit replayed (1/1, no conflicts). HEAD a93def3c3. Does not merge. |
Register OpenAI dall-e-3 in the image registry so the unprefixed scan no longer binds it to Designer Web. Prefixed microsoft-designer-web/dall-e-3 stays Designer. Chat catalog skip (#6457) then hides openai/dall-e-3. Fixes #10832 Signed-off-by: Ravi Tharuma <RaviTharuma@users.noreply.github.com>
a93def3 to
b496644
Compare
|
Removed the shared #10828 drain commits from this branch so the diff is feature-only again (it had been ~100 files of i18n/catalog/CI dump stacked under the real change). Rebased onto current |
|
Quality ratchet on |
|
Remaining Quality Gates on
None of that is the dall-e-3 routing change (3 files). Not restacking the drain. Does not merge. |
80a59c0
into
cheaper-inference:release/v3.8.50
Merged — validated together with a batch of related RaviTharuma PRs in one combined worktree (typecheck:core clean, complexity/file-size/changelog gates green, focused tests passing). Thanks for the contribution!
Summary
dall-e-3inIMAGE_PROVIDERS.openai.modelsso the unprefixedparseImageModel()scan resolvesdall-e-3to OpenAI Images instead of Microsoft Designer Web.microsoft-designer-web/dall-e-3andmsdesigner/dall-e-3stay on Designer Web.#6457skips registered image models from the chat catalog,openai/dall-e-3no longer appears as a 128k chat model.Related Issues
Validation
npx eslinton the two TypeScript files in this PRrelease/v3.8.50); focused checks rerun afterwardLocal gates (this host does not run the full unit suite or production build):
npm run check:file-size— OK (registry did not grow past the freeze)node --import tsx/esm --import ./open-sse/utils/setupPolyfill.ts --test tests/unit/unprefixed-dalle3-10832.test.ts tests/unit/cheaperinference-image-models.test.ts— 5 passTests Added Or Updated
tests/unit/unprefixed-dalle3-10832.test.ts(new; frozenimage-generation-handler.test.tsleft untouched)Coverage Notes
open-sse/config/imageRegistry.ts:parseImageModel("dall-e-3")now returns{ provider: "openai", model: "dall-e-3" };isRegisteredImageModel("openai", "dall-e-3")is true;getAllImageModels()includesopenai/dall-e-3.Reviewer Notes
dall-e-3id. Only the unprefixed scan changes, via OpenAI being listed first inIMAGE_PROVIDERS.