Skip to content

fix(images): route bare dall-e-3 to OpenAI - #10847

Merged
diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.50from
RaviTharuma:fix/10832-unprefixed-dalle3
Aug 20, 2026
Merged

diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.50from
RaviTharuma:fix/10832-unprefixed-dalle3

Conversation

@RaviTharuma

Copy link
Copy Markdown
Contributor

Summary

  • Register OpenAI dall-e-3 in IMAGE_PROVIDERS.openai.models so the unprefixed parseImageModel() scan resolves dall-e-3 to OpenAI Images instead of Microsoft Designer Web.
  • Prefixed microsoft-designer-web/dall-e-3 and msdesigner/dall-e-3 stay on Designer Web.
  • Because #6457 skips registered image models from the chat catalog, openai/dall-e-3 no longer appears as a 128k chat model.

Related Issues

Validation

  • Change type: provider / routing
  • Focused tests and category gates from the golden path
  • npx eslint on the two TypeScript files in this PR
  • Reconciled with the current active release base (release/v3.8.50); focused checks rerun afterward
  • Production-code changes include a new or updated automated test in this PR
  • SonarQube is temporarily opt-in while the private project has no quota; it is not a PR gate.

Local gates (this host does not run the full unit suite or production build):

  • npm run check:file-size — OK (registry did not grow past the freeze)
  • node --import tsx/esm --import ./open-sse/utils/setupPolyfill.ts --test tests/unit/unprefixed-dalle3-10832.test.ts tests/unit/cheaperinference-image-models.test.ts — 5 pass

Tests Added Or Updated

  • tests/unit/unprefixed-dalle3-10832.test.ts (new; frozen image-generation-handler.test.ts left untouched)

Coverage Notes

  • open-sse/config/imageRegistry.ts: parseImageModel("dall-e-3") now returns { provider: "openai", model: "dall-e-3" }; isRegisteredImageModel("openai", "dall-e-3") is true; getAllImageModels() includes openai/dall-e-3.
  • Coverage on the frozen handler test file is unchanged.

Reviewer Notes

  • Designer Web still owns the prefixed dall-e-3 id. Only the unprefixed scan changes, via OpenAI being listed first in IMAGE_PROVIDERS.
  • No credential, hostname, or operator combo names in this PR.

@RaviTharuma
RaviTharuma force-pushed the fix/10832-unprefixed-dalle3 branch 2 times, most recently from d50d41f to 87ede03 Compare August 20, 2026 13:39
@RaviTharuma

Copy link
Copy Markdown
Contributor Author

Rebased onto current release/v3.8.50 via #10828 (af26008fc). Unique commit replayed on the drain HEAD. Pre-rebase FQG was the shared 5-gate baseline (public-creds / mutation-test-coverage / dead-code / open-sse-typecheck / secrets). Merge is MERGEABLE. Does not merge.

@RaviTharuma
RaviTharuma force-pushed the fix/10832-unprefixed-dalle3 branch from 87ede03 to a492e73 Compare August 20, 2026 13:53
@RaviTharuma

Copy link
Copy Markdown
Contributor Author

Rebased onto current release/v3.8.50 via #10828 (0a09b6ac0 / 4821f9f). Unique image-routing commit replayed (1/1, no conflicts). HEAD a492e737b. Does not merge.

@RaviTharuma
RaviTharuma force-pushed the fix/10832-unprefixed-dalle3 branch from a492e73 to a93def3 Compare August 20, 2026 13:56
@RaviTharuma

Copy link
Copy Markdown
Contributor Author

Rebased onto current #10828 (8f4cced43). Unique image-routing commit replayed (1/1, no conflicts). HEAD a93def3c3. Does not merge.

Register OpenAI dall-e-3 in the image registry so the
unprefixed scan no longer binds it to Designer Web.
Prefixed microsoft-designer-web/dall-e-3 stays Designer.
Chat catalog skip (#6457) then hides openai/dall-e-3.

Fixes #10832

Signed-off-by: Ravi Tharuma <RaviTharuma@users.noreply.github.com>
@RaviTharuma
RaviTharuma force-pushed the fix/10832-unprefixed-dalle3 branch from a93def3 to b496644 Compare August 20, 2026 13:57
@RaviTharuma

Copy link
Copy Markdown
Contributor Author

Removed the shared #10828 drain commits from this branch so the diff is feature-only again (it had been ~100 files of i18n/catalog/CI dump stacked under the real change). Rebased onto current release/v3.8.50 (4821f9ffd). Does not merge.

@RaviTharuma

Copy link
Copy Markdown
Contributor Author

Quality ratchet on b4966449 failed i18nUiCoverage.pct 99.3 < baseline 100 (ESLint itself 0/0). That is the shared release/v3.8.50 i18n-key gap already drained on #10828, not the dall-e-3 routing change. Not restacking the locale dump onto this PR. Does not merge.

@RaviTharuma

Copy link
Copy Markdown
Contributor Author

Remaining Quality Gates on b4966449 after the i18n ratchet:

  • Docs Gates: check:docs-sync (42 docs/i18n/*/llm.txt vs root llm.txt)
  • FQG 5-gate baseline: public-creds / mutation-test-coverage / dead-code / open-sse-typecheck / secrets
  • Unit 1-4: shared release leftovers (#10225/#10503 overflow, OpenRouter warmup, combo live retry, locale parity) — already drained on chore(ci): ignore ad-hoc BOT_TOKEN/BOT_URL in env-doc-sync #10828

None of that is the dall-e-3 routing change (3 files). Not restacking the drain. Does not merge.

@diegosouzapw
diegosouzapw merged commit 80a59c0 into cheaper-inference:release/v3.8.50 Aug 20, 2026
5 checks passed
@RaviTharuma
RaviTharuma deleted the fix/10832-unprefixed-dalle3 branch September 23, 2026 19:37
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
Merged — validated together with a batch of related RaviTharuma PRs in one combined worktree (typecheck:core clean, complexity/file-size/changelog gates green, focused tests passing). Thanks for the contribution!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(images): unprefixed dall-e-3 resolves to Microsoft Designer Web, not OpenAI

2 participants