Repository navigation
fix(catalog): scope combo reasoning efforts by connection - #10723
Merged
diegosouzapw merged 3 commits intoAug 20, 2026
Merged
diegosouzapw merged 3 commits into
diegosouzapw merged 3 commits into
Conversation
Contributor
Author
CI baseline verificationI investigated every red check from this PR against the exact base commit,
The base/head relationship remains one commit directly on |
4 of 5 tasks
Port the reasoning_efforts model-capability override from cheaper-inference#10724 into this branch, reconciled with the connection-scoped effort-tiers fail-closed guarantee already in place here. A `reasoning_efforts` override is now authoritative provider-scoped evidence for combo effort_tiers resolution -- it is applied before (and is never silently dropped by) the per-connection synced-catalog fail-closed scan, and the existing skipCanonicalEffortFallback: true fail-closed behavior is preserved unchanged for models without an override. Also fixes a dead branch in parseReasoningEffortsOverride: `.split(",")` on an ASCII string never returns an empty array, so the `segments.length === 0` guard could never fire; the existing per-item empty-check already covers "" and trailing commas correctly. Co-authored-by: Xiangzhe <32761048+xz-dev@users.noreply.github.com>
Resolves the base-drift documented in _tasks/pipeline/prs/1-analyzed/10723-*.plan.md (cheaper-inference#9147 catalog cooperative-yield + a released signature change on getCanonicalModelMetadata's snapshot parameter — kept the release's object-bundled-snapshot signature, adapted the two call sites this PR touched).
diegosouzapw
merged commit Aug 20, 2026
9fc3b29
into
cheaper-inference:release/v3.8.50
6 checks passed
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…ference#10723) Merged — locally validated (72/72 focused tests, typecheck:core clean, all static gates green) after resolving base-drift conflicts (catalog.ts cooperative-yield insertion point, modelMetadataRegistry.ts snapshot-param signature). CI's red checks (Unit Tests fast-path shards, Fast Quality Gates, Docs Gates) are confirmed PRE-EXISTING base-red on the pure release tip — reproduced tests/unit/db-driver-bundling-externals.test.ts, tests/unit/model-catalog-runtime-invalidation.test.ts and others failing identically against origin/release/v3.8.50 with zero PR content, unrelated to this change. Thanks for the design and for absorbing cheaper-inference#10724's value here — great work on both review rounds!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
low/medium/highreasoning-effort vocabulary from one shared runtime source of truth.effort_tiersfrom the exact runtime-selectable connection scope: dynamic accounts, pinnedconnectionId,allowedConnectionIds, built-in aliases, and compatible provider-node public prefixes.supportedThinkingEfforts; model names and generic reasoning heuristics never synthesize combo tiers.Related Issues
Validation
Choose the change type and focused loop from the
Contribution Golden Path. The full unit suite,
Vitest, the 60% coverage gate, and the production build all run in CI on this PR (#8329):
node --import tsx --test tests/unit/catalog-helpers-extraction.test.ts tests/unit/models-catalog-combo-metadata.test.ts tests/unit/provider-models-discovery-split.test.ts tests/unit/grok-cli-responses-compat.test.tsnpm run typecheck:corenpm run typecheck:noimplicit:corenpm run check:dashboard-typechecknpm run i18n:check-ui-coveragenpm run i18n:check-value-driftnpm run check:changelog-integritygit diff --checknpm run lint@typescript-eslint/no-explicit-anyerrors intests/unit/cli-oauth-commands.test.tsandtests/unit/executor-gitlab.test.ts.origin/release/v3.8.50@b754e44e260ba888035b8ec077b4da8ea4483e48; this branch is one commit directly on that base.Additional baseline note:
npm run check:open-sse-typecheckreportsopen-sse/executors/index.ts(239,27) TS2345for the pre-existingGlmExecutor.buildHeaderssignature mismatch. The exact diagnostic reproduces in a detached clean worktree atorigin/release/v3.8.50; this PR does not modify that path.Tests Added Or Updated
tests/unit/catalog-helpers-extraction.test.tstests/unit/grok-cli-responses-compat.test.tstests/unit/models-catalog-combo-metadata.test.tstests/unit/provider-models-discovery-split.test.tsCoverage Notes
/v1/modelsregressions cover dynamic intersection, pinned and allowlisted scopes, malformed persisted catalogs, compatible provider-node prefixes, and unknown multi-target fail-closed behavior.Reviewer Notes