Repository navigation
test(chatcore): wait for queued call log writes - #10683
diegosouzapw merged 1 commit into
Conversation
61dd280 to
abcb929
Compare
|
Thanks — this fixes a real latent bug: Note: the title and PR body call this a "test-only follow-up," but the PR also carries a production change in Before this can merge, the branch needs:
Keep the existing tests green; do not weaken/remove the new assertions to pass. Happy to re-review once the conflict is resolved and CI is green. |
6d862ad to
99d0414
Compare
99d0414 to
38306b6
Compare
2a10d16
into
cheaper-inference:release/v3.8.50
Merged — locally validated (110/110 focused tests, typecheck:core clean, gates green) after resolving base-drift against #10683 (both landed today, same test file — combined). Nice, well-tested cache-breakpoint fix. Thanks!
…inference#10684) Merged — locally validated (110/110 focused tests, typecheck:core clean, gates green) after resolving base-drift against cheaper-inference#10683 (both landed today, same test file — combined). Nice, well-tested cache-breakpoint fix. Thanks!
CI note:
Docs Gatescurrently inherits the release-baseBOT_TOKEN/BOT_URLenv-doc failure. the same base-red appears on unrelated #10780; this diff does not touch those variables.The chatcore translation suite could read
call_logsbefore queued writes finished. latest-record assertions then saw stale rows.This PR only changes test timing. production behavior stays the same.
The shared helper now waits for
waitForCallLogSaves(5000)before reading the latest call log.release/v3.8.50owns the SSE comment behavior updated in #10726, so this branch leaves those assertions unchanged.how to test
The focused file passes after rebasing onto the current release tip. direct-file ESLint still reports 31
no-explicit-anyfindings present on the release base; this three-line diff adds none.