Repository navigation
perf(electron): defer hidden-start renderer creation (3/8) - #10327
Merged
diegosouzapw merged 1 commit intoAug 20, 2026
Merged
diegosouzapw merged 1 commit into
diegosouzapw merged 1 commit into
Conversation
31 of 37 tasks
backryun
force-pushed
the
perf/electron-lazy-hidden-renderer
branch
4 times, most recently
from
August 14, 2026 15:54
54ba574 to
ff4f686
Compare
backryun
force-pushed
the
perf/electron-lazy-hidden-renderer
branch
6 times, most recently
from
August 15, 2026 01:52
df63506 to
811244f
Compare
backryun
force-pushed
the
perf/electron-lazy-hidden-renderer
branch
8 times, most recently
from
August 16, 2026 09:33
b0b8796 to
03d6ca5
Compare
Collaborator
|
Deferido para revalidação do head atual. A rodada anterior registrou um hold de ownership, mas a inspeção atual não confirmou esse worktree; por favor, reconfirme o head e os checks antes da decisão final. |
backryun
force-pushed
the
perf/electron-lazy-hidden-renderer
branch
from
August 17, 2026 08:51
03d6ca5 to
2646c43
Compare
backryun
force-pushed
the
perf/electron-lazy-hidden-renderer
branch
2 times, most recently
from
August 17, 2026 17:42
8fc201a to
9d9a084
Compare
backryun
force-pushed
the
perf/electron-lazy-hidden-renderer
branch
11 times, most recently
from
August 20, 2026 13:23
fdee454 to
6534348
Compare
backryun
force-pushed
the
perf/electron-lazy-hidden-renderer
branch
from
August 20, 2026 13:39
6534348 to
69e929a
Compare
diegosouzapw
merged commit Aug 20, 2026
5e50814
into
cheaper-inference:release/v3.8.50
5 checks passed
diegosouzapw
pushed a commit
that referenced
this pull request
Aug 20, 2026
Merged — locally validated (73/73 focused electron tests, typecheck:core clean, gates green) after resolving base-drift against #10327 (both landed today, real interleaved logic in createWindow/showMainWindow/window-all-closed — combined so the hidden-start lazy-open path from #10327 and the unload-on-close path from this PR both stay intact; verified by the existing test 'keeps the non-macOS app alive when unloading its last renderer'). Nice pair of electron perf PRs, thanks!
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…ce#10327) Merged — locally validated (6/6 focused lazy-window tests, plus the wider electron suite, typecheck:core clean, gates green). Thanks!
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…ference#10328) Merged — locally validated (73/73 focused electron tests, typecheck:core clean, gates green) after resolving base-drift against cheaper-inference#10327 (both landed today, real interleaved logic in createWindow/showMainWindow/window-all-closed — combined so the hidden-start lazy-open path from cheaper-inference#10327 and the unload-on-close path from this PR both stay intact; verified by the existing test 'keeps the non-macOS app alive when unloading its last renderer'). Nice pair of electron perf PRs, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #10321 (stage 3).
What changed
Measured impact
Comparable local macOS arm64 development runs used Electron 43.3.0, a fresh isolated user-data directory, --hidden, no running Next server, and an 8-second stabilization period. RSS is the complete Electron process tree.
These are local development measurements, not packaged-release guarantees. They show that the renderer is absent while hidden and created again on demand.
Validation
The measurement-only electron/node_modules installation and isolated user-data directories were removed after the run.