Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@sleshchenko
Copy link
Contributor

@sleshchenko sleshchenko commented Mar 31, 2021

What does this PR do?

Finalize devworkspace to workspace renaming.
It depends on devfile/devworkspace-operator#322. ⚠️ after <- is merged, it's needed to update go.mod versions before merging.

What issues does this PR fix or reference?

it's done for devfile/devworkspace-operator#321

@metlos
Copy link
Collaborator

metlos commented Mar 31, 2021

The failed PR check is curious - https://github.com/che-incubator/devworkspace-che-operator/pull/31/checks?check_run_id=2237523423. Are you using an old version of controller-gen:0.3.0 (and therefore apiextensions.k8s.io/v1beta1 for the CRDs) intentionally in DWO?

@sleshchenko sleshchenko force-pushed the workspace2DevWorkspace branch from 373340a to 422854b Compare April 2, 2021 16:16
@sleshchenko
Copy link
Contributor Author

Are you using an old version of controller-gen:0.3.0 (and therefore apiextensions.k8s.io/v1beta1 for the CRDs) intentionally in DWO?

Well, nobody care about the newer controller-gen usage, and AFAIS, the only difference is formatting, but I may be wrong.
But it suggests that both of DWO and this repo have issue: rely on the installed version when specific is needed.
The fix is to download the required versions into cache folder and redownload it when version is not right, like we do here https://github.com/devfile/devworkspace-operator/blob/main/deploy/generate-deployment.sh#L130
But it's out of this issue.

@sleshchenko sleshchenko force-pushed the workspace2DevWorkspace branch 2 times, most recently from 5826643 to 7836f0c Compare April 2, 2021 16:25
@sleshchenko sleshchenko marked this pull request as ready for review April 5, 2021 11:07
Copy link
Collaborator

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please make sure the deps in go.mod are up-to-date before merging.

@sleshchenko sleshchenko force-pushed the workspace2DevWorkspace branch from 7836f0c to cc1be9d Compare April 8, 2021 10:46
@sleshchenko sleshchenko force-pushed the workspace2DevWorkspace branch from cc1be9d to ff19a79 Compare April 8, 2021 13:24
@sleshchenko
Copy link
Contributor Author

set the right version for DWO

@sleshchenko sleshchenko merged commit 95f6541 into che-incubator:main Apr 8, 2021
@sleshchenko sleshchenko deleted the workspace2DevWorkspace branch April 8, 2021 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants