Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github workflow triggers #799

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

annarhughes
Copy link
Member

@annarhughes annarhughes commented Jan 8, 2024

What changes did you make?

Fixed the workflow triggers (e.g. on: push: branches: [develop]) so that actions are also run on push and not just pull_request. The push to develop trigger is required for the first commit from develop -> main

Why did you make the changes?

The following actions weren't being run on the initial commit on develop -> main PRs:

  • cypress release tests
  • build and test

See #797 for example of the first commit actions not including cypress release tests and build and test on the initial commit. From the second commit, those actions were run.

Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bloom-frontend ✅ Ready (Inspect) Visit Preview Jan 8, 2024 11:20am

@annarhughes annarhughes merged commit ee65475 into develop Jan 8, 2024
@annarhughes annarhughes deleted the fix-github-workflow-triggers branch January 8, 2024 11:23
@cypress cypress bot mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant