-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the code-open to all! #83
Labels
help wanted
Extra attention is needed
Comments
@chavi362 I would like to work on it, do i start working or you'll assign it first |
Yes, you can do that.
This issue doesn't required assignments, everyone who find code that can
became shorter can submit a pr
Good Luck 🤞
Chavi
בתאריך יום א׳, 4 בפבר׳ 2024 ב-10:51 מאת Saksham Jain <
***@***.***>:
… @chavi362 <https://github.com/chavi362> I would like to work on it, do i
start working or you'll assign it first
—
Reply to this email directly, view it on GitHub
<#83 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBPQEONNXG4I7UVUOZXPXA3YR5DZFAVCNFSM6AAAAABB5DWCKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGY2DCNBXHE>
.
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
If you still prefer that I assign you, please let me know
בתאריך יום א׳, 4 בפבר׳ 2024 ב-17:59 מאת Chavi developer <
***@***.***>:
… Yes, you can do that.
This issue doesn't required assignments, everyone who find code that can
became shorter can submit a pr
Good Luck 🤞
Chavi
בתאריך יום א׳, 4 בפבר׳ 2024 ב-10:51 מאת Saksham Jain <
***@***.***>:
> @chavi362 <https://github.com/chavi362> I would like to work on it, do i
> start working or you'll assign it first
>
> —
> Reply to this email directly, view it on GitHub
> <#83 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BBPQEONNXG4I7UVUOZXPXA3YR5DZFAVCNFSM6AAAAABB5DWCKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVGY2DCNBXHE>
> .
> You are receiving this because you were mentioned.
> Message ID: ***@***.***>
>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now the code is very bigger.
If you can update some function to be generic. Or you find repeated code, you can submit a PR on this!
Note that the code should work the same as before and be readable and efficient !
The text was updated successfully, but these errors were encountered: