-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make object notation usable for polarArea and radar #10088
Merged
etimberg
merged 6 commits into
chartjs:master
from
LeeLenaleee:feature/parsing-polarArea
Feb 12, 2022
Merged
Make object notation usable for polarArea and radar #10088
etimberg
merged 6 commits into
chartjs:master
from
LeeLenaleee:feature/parsing-polarArea
Feb 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
reviewed
Jan 18, 2022
kurkle
reviewed
Jan 19, 2022
LeeLenaleee
changed the title
Make object notation usable for polarArea
Make object notation usable for polarArea and radar
Jan 21, 2022
kurkle
approved these changes
Jan 21, 2022
etimberg
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to do a lot of cleaning, lots of code duplication atmLive example: https://codepen.io/leelenaleee/pen/LYzvBKz
Resolves #10086