-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Capitalization #118
Conversation
This looks nice, thank you! I imagine an option for using title case would also be appreciated. Could you also try and add a test-case for these styling options? |
Sure, I'm going to work on that! |
I got rid of the example file, since there now is a unit test for the capitalization options. var s bool = true
var p *bool = &s
style := DarkStyleConfig
style.H1.Upper = p
style.H2.Title = p
style.H3.Lower = p Is there a cleaner way to do this? |
Only slightly, but still nicer to read: b := true
style.H1.Upper = &b |
Thanks! I updated that section in the code. |
Thank you for your contribution! ❤️ |
You're welcome! |
Fixes #100 (adds lower and upper case styling).
I used an example, in which
h1
andh3
tags were wrongly capitalized. This produced the following output:You can rerun the example, by running
go run examples/capitalization/main.go
and by makingh1
upper case andh3
lower case by adding the following lines tostyles.go
: