fix issue where lists that didn't start at 1 were not respected #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Would you mind adding a test for that functionality? |
|
Resolved via 39dc9a7. I'm not entirely sure what the workflow is for new tests, but I made one, stubbed out generateExamples, and spot-checked the generated result as correct. |
|
Thank you for your contribution! ❤️ |
|
Do you have any release cadence? I'd love a tag sometime in the next week or two |
|
I still have a few issues I'd like to get in for the next release, but in the next week or two sounds reasonable. You can always pin your import to a specific commit in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is more thoroughly elaborated in this issue for a depending project. The tl;dr is that most/all markdown processors will respect the first number in a numbered list, and ignore all subsequent values. The commonmark reference implementation implements this, and github flavored markdown respects this as well.
This change is to recalculate the list enumeration value based on the starting number in the list. It has been manually tested, and lists starting at 0 are rendered correctly as well.
Sample showing fixed behavior:
Sample showing fixed behavior with 0:
