Skip to content
This repository was archived by the owner on Mar 6, 2025. It is now read-only.

Conversation

@sergiught
Copy link

🔧 Changes

In this PR we are bumping github.com/dgraph-io/badger from v3.2103.2 to v4.2.0 (Changelog).

Furthermore the Go version within the go.mod file was also updated from 1.17 to 1.22 (latest). As far as I can tell Badger v4 doesn't rely on features or standard library changes introduced after Go 1.17. This was done mainly to avoid running commands such as go mod tidy -go=1.16 && go mod tidy -go=1.17 for dependency bumps in the future.

🔬 Testing

Other than running go test -race ./... I executed the following as well:

go run main.go kv set myKey myValue
go run main.go kv get myKey
go run main.go kv list 
go run main.go kv reset
go run main.go kv sync
go run main.go kv delete myKey

No issues found.

image

I also ran govulncheck ./... with the following result:

=== Symbol Results ===

No vulnerabilities found.

Your code is affected by 0 vulnerabilities.
This scan also found 1 vulnerability in packages you import and 2
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.

Note

I'm more than happy to help out with bumping any other deps if there's an appetite, I was mostly interested in having the latest version of badger.

@sergiught sergiught marked this pull request as ready for review August 5, 2024 18:28
@caarlos0
Copy link
Member

Hey, the charm cloud is discontinued, so this is out of our roadmap.

https://github.com/charmbracelet/charm?tab=readme-ov-file#sunsetting-charm-cloud

Closing the issue, but feel free to comment if you have further questions.

@caarlos0 caarlos0 closed this Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants