Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade ActiveJob dependency to 4.2 #54

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Downgrade ActiveJob dependency to 4.2 #54

merged 1 commit into from
Jun 5, 2018

Conversation

iacobus
Copy link
Contributor

@iacobus iacobus commented May 29, 2018

Hi, thank you for your work with Gush. We're considering using it for a Rails 4.2 project but the gemspec currently has a ~> 5.0 dependency. However, we don't think that there are any meaningful differences for gush — all tests pass with 4.2.

Is there anything else that we should be checking? If not, what do you think about merging this? I imagine there are still a good number of Rails 4 projects out there.

Thank you!

@pokonski
Copy link
Contributor

pokonski commented May 29, 2018

Hey, Jacobo! I don't think 5 is required but can you make it more relaxed? Like this:

'>= 4.2' , '< 6.0'

? Can't be sure of the syntax but should be close to it :) This way we can have people using Rails 5 happy, too.

@iacobus
Copy link
Contributor Author

iacobus commented May 29, 2018

@pokonski yes, definitely. I always get those wrong. I made it 4.2.7, sort of randomly. Tests pass in that precise version, as well as latest 4.x (4.2.10). Thank you.

@iacobus
Copy link
Contributor Author

iacobus commented Jun 5, 2018

Hi @pokonski — any next steps here, or is it good to merge? :)

@pokonski
Copy link
Contributor

pokonski commented Jun 5, 2018

Good to go! Sorry, missed the fact that you pushed the update :)

I will push a new version later today and let you know here!

@pokonski pokonski merged commit e912cdb into chaps-io:master Jun 5, 2018
@iacobus
Copy link
Contributor Author

iacobus commented Jun 6, 2018

Oh, great. Thank you @pokonski — what's the release cadence? Should I expect a new version including this to come out soon?

[EDIT: I'm sorry, I missed the second line of your message... Disregard my note. Thanks!]

@pokonski
Copy link
Contributor

pokonski commented Jun 9, 2018

@iacobus 1.1.1 is now released and contains your change, thanks again! Wasn't "later today", sorry for that 😁

@iacobus
Copy link
Contributor Author

iacobus commented Jun 11, 2018

🚀 thank you!

@iacobus iacobus deleted the downgrade_active_job_dependency branch June 11, 2018 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants