Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist dependencies so that Workflow#configure is not required on load #118

Merged

Commits on Jul 24, 2024

  1. Persist dependencies so that Workflow#configure is not required on …

    …load
    
    Previously, `Workflow#configure` was called every time a Workflow was
    instantiated. This could create broken dependency graphs, e.g. if a
    configure method sets up job dependencies based on some mutable data like
    a timestamp argument or a database value.
    
    Instead, serialize workflow dependencies along with the rest of a workflow's
    data and reload it via `Client#workflow_from_hash` and tell `Workflow#initialize`
    not to run setup/configure.
    
    Note that for backwards compatibility with workflows persisted before this
    change, the setup method will still be called if dependencies in the
    deserialized hash are nil.
    noahfpf committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c96287f View commit details
    Browse the repository at this point in the history