add missing json attribute to Gush::Job #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokonski
reviewed
Jul 16, 2024
lib/gush/job.rb
Outdated
| workflow_id: workflow_id, | ||
| output_payload: output_payload | ||
| queue:, | ||
| incoming:, |
There was a problem hiding this comment.
Omitting hash values is a Ruby 3.1 feature. We still target 3.0 for compatibility
https://github.com/chaps-io/gush/blob/master/.github/workflows/ruby.yml#L30
There was a problem hiding this comment.
Omitting hash values is a Ruby 3.1 feature. We still target 3.0 for compatibility
https://github.com/chaps-io/gush/blob/master/.github/workflows/ruby.yml#L30
thanks, fixed
|
Good catch, thank you! Can you just revert the issue I mentioned above with hash values? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added missing :wait attribute to Gush::Job#as_json because that argument was skipped when Gush::Job#persist_job called so sidekiq job was performed with no delay even if :wait was specified