Add globals and kwargs to Workflow and Job #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For shared functionality across Workflow classes that depends on some variable data, it's useful to have named parameters for the Workflow that are automatically forwarded to all Job instances. This commit adds a `globals` keyword arg to the Workflow initializer, which should be a hash that is then stored in a `globals` hash attribute, is persisted, and is merged into the `params` sent to each Job instance.
For workflows that take a larger number of parameters or optional parameters, it's useful to specify these as keyword arguments rather than positional ones. This commit adds support to `Workflow#initialize` for kwargs, and stores them in a new `kwargs` attribute.
|
Thank you for this, this is a good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add globals to Workflow and Job
For shared functionality across Workflow classes that depends on some variable
data, it's useful to have named parameters for the Workflow that are
automatically forwarded to all Job instances.
This commit adds a
globalskeyword arg to the Workflow initializer, whichshould be a hash that is then stored in a
globalshash attribute, ispersisted, and is merged into the
paramssent to each Job instance.Add kwargs to Workflow
For workflows that take a larger number of parameters or optional parameters,
it's useful to specify these as keyword arguments rather than positional ones.
This commit adds support to
Workflow#initializefor kwargs, and stores themin a new
kwargsattribute.