Remove uses of FILENAME_MAX in the runtime
#26381
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: R Chinmay <[email protected]>
Signed-off-by: R Chinmay <[email protected]>
Signed-off-by: R Chinmay <[email protected]>
Signed-off-by: R Chinmay <[email protected]>
Signed-off-by: R Chinmay <[email protected]>
Signed-off-by: R Chinmay <[email protected]>
…me-max New uses of FILENAME_MAX mark where HEAD switched to snprintf (with a FILENAME_MAX buffer size), while the merged-in work used the sprintf that was present at the time. These are to be updated shortly to use a more sensible buffer size. Signed-off-by: Anna Rift <[email protected]>
Also includes some formatting fixes Signed-off-by: Anna Rift <[email protected]>
riftEmber
force-pushed
the
runtime-no-filename-max
branch
from
c6a81b4 to
57476c2
Compare
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
riftEmber
force-pushed
the
runtime-no-filename-max
branch
from
72b95c3 to
d0fb700
Compare
riftEmber
changed the title
FILENAME_MAX in the runtime
riftEmber
force-pushed
the
runtime-no-filename-max
branch
from
b2e7363 to
47ec125
Compare
Signed-off-by: Anna Rift <[email protected]>
riftEmber
force-pushed
the
runtime-no-filename-max
branch
from
47ec125 to
2f0efff
Compare
To avoid out-of-scope change Signed-off-by: Anna Rift <[email protected]>
riftEmber
force-pushed
the
runtime-no-filename-max
branch
from
bde7965 to
6f0911a
Compare
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
jabraham17
requested changes
Dec 9, 2024
runtime/src/launch/slurm-gasnetrun_common/slurm-gasnetrun_common.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
riftEmber
force-pushed
the
runtime-no-filename-max
branch
from
4c99306 to
04c552b
Compare
riftEmber
force-pushed
the
runtime-no-filename-max
branch
18 times, most recently
from
20a2f46 to
2344862
Compare
Signed-off-by: Anna Rift <[email protected]>
jabraham17
reviewed
Dec 16, 2024
runtime/src/launch/slurm-gasnetrun_common/slurm-gasnetrun_common.h
Outdated
Show resolved
Hide resolved
runtime/src/launch/slurm-gasnetrun_common/slurm-gasnetrun_common.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Anna Rift <[email protected]>
jabraham17
approved these changes
Dec 17, 2024
runtime/src/launch/slurm-gasnetrun_common/slurm-gasnetrun_common.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
vasslitvinov
added a commit
that referenced
this pull request
Dec 21, 2024
This safeguards spaces and most other symbols in the arguments passed to
a compiled Chapel program that uses a slurm launcher, where such a
safeguard was missing. For example:
./myProgram --myString='Hello, world!'
used to behave as if it were `./myProgram --myString=Hello, world!`,
i.e., `world!` would be passed as a separate argument to
`myProgram_real` when launched with slurm.
This is a stopgap solution to ensure that the test augmented in #26439
passes in slurm configurations. It is not bullet-proof because user
arguments containing single quotes and/or backslashes will not be passed
through properly.
Next steps: #26381 eliminates static limits on the size of user
arguments. In the long run we want to switch from launching using
`system()`, when quoting may be necessary, to using `execvp` to avoid
the need to quote.
Discussed with Brad and Anna.
This reverts commit 7c9306a. Signed-off-by: Anna Rift <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace uses of
FILENAME_MAXfor buffer sizes in the runtime, replacing them with heap-allocated strings of the proper size that are reallocated as needed.Merges in and builds on the work by @rchinmay in #17059.
Completes the second part of #8757 (with #26357).
[reviewer info placeholder]
Testing: