Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport More Qthreads Performance Fixes #26328

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

insertinterestingnamehere
Copy link
Contributor

Backporting two more performance fixes from sandialabs/qthreads#314.

Copy link
Member

@jabraham17 jabraham17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting this!

@bradcray
Copy link
Member

@insertinterestingnamehere / @jabraham17 : Just noting that main was unfrozen today, so we could merge this on a quiet day to see the performance impacts. It remains to be seen whether today will be quiet or see a flood of merges from developers who've just been waiting…

@jabraham17
Copy link
Member

I was planning to wait until after the flood of other PRs for this one in particular

@jabraham17 jabraham17 merged commit c93e20f into chapel-lang:main Dec 12, 2024
7 checks passed
jabraham17 added a commit that referenced this pull request Dec 12, 2024
Annotate backported qthreads perf fix from
#26328

[Not reviewed - trivial]
jabraham17 added a commit that referenced this pull request Jan 6, 2025
Partially reverts a Qthreads patch from #26328 which resulted in a
performance penalty. The patch was meant to fix some performance
regressions, but instead caused more than it helped.

This PR only reverts the changes to the definition of MACHINE_FENCE.

Closes #26440

[Reviewed by @jhh67]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants