-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve basic associative domains with module code in Dyno #26077
Draft
riftEmber
wants to merge
16
commits into
chapel-lang:main
Choose a base branch
from
riftEmber:dyno-associative-domains
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riftEmber
force-pushed
the
dyno-associative-domains
branch
2 times, most recently
from
October 14, 2024 15:37
a365a3f
to
8070e30
Compare
riftEmber
force-pushed
the
dyno-associative-domains
branch
7 times, most recently
from
October 31, 2024 19:56
cadb922
to
87170da
Compare
riftEmber
force-pushed
the
dyno-associative-domains
branch
12 times, most recently
from
November 22, 2024 19:53
62eab18
to
262abef
Compare
riftEmber
changed the title
Resolve basic associative domains with module code in Dyno
Test basic associative domains with module code in Dyno
Nov 22, 2024
riftEmber
changed the title
Test basic associative domains with module code in Dyno
Resolve basic associative domains with module code in Dyno
Nov 22, 2024
riftEmber
force-pushed
the
dyno-associative-domains
branch
2 times, most recently
from
November 26, 2024 19:57
9b06d78
to
10b93b0
Compare
riftEmber
force-pushed
the
dyno-associative-domains
branch
2 times, most recently
from
December 2, 2024 19:17
1a03aef
to
9d69475
Compare
riftEmber
force-pushed
the
dyno-associative-domains
branch
2 times, most recently
from
December 20, 2024 19:26
822d66a
to
ed1773b
Compare
riftEmber
force-pushed
the
dyno-associative-domains
branch
7 times, most recently
from
December 20, 2024 22:24
2f5c64b
to
4e8086f
Compare
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
- Return true from resolveFnCallSpecial if handled - Invert result for != Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
riftEmber
force-pushed
the
dyno-associative-domains
branch
from
December 23, 2024 16:59
4e8086f
to
1c759b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get associative domains resolving using their module code in Dyno, and re-enable testing.
This PR itself contains little work and mostly just drove Dyno work needed to support the module code.
Completes part of https://github.com/Cray/chapel-private/issues/6729.
Also includes:
helpResolveFunction
to run on generic type constructors, per bug fix suggestion from Benparam == ?
comparisons which was introduced in Dyno: Improve initialization of fields from non-matching types #26219, so that it gets specially handled rather than trying to resolve a defined==
operator[reviewer info placeholder]
Testing: