-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates towards enabling nilability checks #13610
Conversation
See classes/deitz/class-numbered/class1-old.chpl classes/marybeth/test_dispatch1-error.chpl which were both reporting the wrong errors.
* Avoids doing retain/release since these relied on 'nil' * Added makeClass to one initializer to work around initializers being confused by on statements.
See test/expressions/if-expr/inside-field.chpl
Works around an issue in library/standard/DataFrames/psahabu/HelloDataFrame related to associative arrays of owned.
To avoid nilibility errors
See param/bharshbarg/paramFieldType
@ben-albrecht - would you please review the TOML/Mason changes? @lydia-duncan - could you review the makeArrayFromOpaque and ZMQ changes? @LouisJenkinsCS - FYI about DistributedBag and DistributedDeque changes. Here I took the most obvious approach of using nilable class types @benharsh - could you look at the compiler changes and anything else? Thanks! |
Does the |
These run a nil check that is disabled under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TOML/mason changes looked reasonable to me.
The |
For https://github.com/Cray/chapel-private/issues/305
This PR addresses about the first 100 failures with --no-legacy-nilable-clases. We are working on getting clean testing in that mode in preparation for enabling it by default.
Compiler changes:
_owned(anymanaged MyClass)
to_owned(borrowed MyClass)
Module changes:
locale?
in the addOn argumentnil
via cast or=
owned
=
overloads on classes (see Overloading assignment (=) on class types #5358 (comment) ) and adjusts mason code to use the new TOMLset
methodsnil
.home
fieldAdditionally adjusts a number of tests to pass with
--no-legacy-nilable-classes
.