Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mason modify bug fix + Mason Makefile update #13563

Merged
merged 7 commits into from
Jul 29, 2019

Conversation

ben-albrecht
Copy link
Member

@ben-albrecht ben-albrecht commented Jul 29, 2019

This PR fixes 2 bugs:

  1. Addresses an arg-parsing bug in mason add/rm
  2. Ensures make mason always rebuilds if any mason source file is modified

Additionally, this PR refactors the masonModify() function body, and updates the masonModify tests to exercise the arg-parsing machinery, so that it would catch the bug fixed here.

Testing

  • local: start_test test/mason

Copy link
Contributor

@oplambeck oplambeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, passed a start test on my end. Couldn't break it or get unexpected behavior playing around with it

Copy link
Contributor

@Spartee Spartee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some nit-picks but overall this is great. Im approving to leave it to you to decide to address nits or not.

@ben-albrecht ben-albrecht merged commit 44a674a into chapel-lang:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants